I attach screenshot with details. I used laptop with Windows 7 64bit, NVidia GPU, 4 GB Ram, 2,2 Ghz Dual Core CPU. I very often use Freehand Brush Tool with Stabilizer and this bug is very annoying for me... Reproducible: Always
Created attachment 98672 [details] Lags while drawing circular shapes.png
In Krita v2.9.10.2ae beta 64bit this bug not appears... It looks like some bad regression... I have remember some very similar artifacts was appear in early versions of Krita 3.0, but it was even without Stabilizer. This bug makes I need to stay at Krita v2.9.10.2ae beta 64bit.
From IRC disscusion about this bug: "<Floatharr_> eliotJ: yup I get the corners too, not in 2.9 though".
Hi,
https://phabricator.kde.org/T2414
Upsss... I forgot to mention. I using Wacom Intuos Pro Medium.
I don't get the jagged edges while using the dynamic brush but I get them when using the freehand brush tool. I used exact same settings given by you. I am also attaching the output I am using wacom intuos4 medium on windows 10, I am using the latest builds from kickstarter announcement -> http://files.kde.org/krita/3/windows/devbuilds/krita-3.0-Beta-master-d330a4a-x64.zip I have nvidia 750ti graphic card
Created attachment 98946 [details] test lines with wacom
Raghavendra kamath <- Thank you for test. I believe you have more powerful PC than mine and this can explain why yours lines are less bended...
Is this still the case after commit bd46e0aa30c5fded9da44566fcd35f1335a550d1 Author: Dmitry Kazakov <dimula73@gmail.com> Date: Tue May 24 13:18:36 2016 +0300 Remove amortizing from the amortizeExactBounds() ? http://files.kde.org/krita/3/windows/devbuilds/krita-3.0-RC-1-master-76608ad-x64.zip has the fix
I have sad news... I tested krita-3.0-RC-1-master-76608ad-x64.zip and I still have bended lines while using Dynamic Brush Tool and Freehand Brush Tool with Stabilizer enabled... :(
I noticed that after turning off OpenGL these bended lines are far, far less noticeable ! It looks like it's related to this bug: https://bugs.kde.org/show_bug.cgi?id=360588 I have hope this will be fixed before 3.0 stable release... :)
Reopened
Git commit 23cbbf8b73cdd6c24a82ab70c8269df2b69a4ef7 by Dmitry Kazakov. Committed on 30/05/2016 at 17:09. Pushed by dkazakov into branch 'master'. Fix "bended lines" stabilizer problem on Windows The problem is that on Windows the tablet events are coming in bunches, not uniformly. Therefore any timing-based smoothing system will not work out of box. This patch adds a special class KisStabilizedEventsSampler, that makes the events uniform. It collects a set of events on a 50ms timeframe and then distributes it uniformly. The timeframe size should correlate with the maximum size of the delays created by the events system. On Windows it is 50ms, on Linux 15-20ms. The timeframe can be configured with "stabilizerSampleSize" config option. Ref T2414 CC:kimageshop@kde.org M +1 -0 libs/ui/CMakeLists.txt M +18 -1 libs/ui/kis_config.cc M +4 -0 libs/ui/kis_config.h M +6 -0 libs/ui/tests/CMakeLists.txt A +64 -0 libs/ui/tests/kis_stabilized_events_sampler_test.cpp [License: GPL (v2+)] A +31 -0 libs/ui/tests/kis_stabilized_events_sampler_test.h [License: GPL (v2+)] A +103 -0 libs/ui/tool/kis_stabilized_events_sampler.cpp [License: GPL (v2+)] A +90 -0 libs/ui/tool/kis_stabilized_events_sampler.h [License: GPL (v2+)] M +42 -28 libs/ui/tool/kis_tool_freehand_helper.cpp http://commits.kde.org/krita/23cbbf8b73cdd6c24a82ab70c8269df2b69a4ef7
Git commit da5496d843237daefd214a7849d2cad0f818b43b by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 31/05/2016 at 07:35. Pushed by rempt into branch 'krita/3.0'. Fix "bended lines" stabilizer problem on Windows The problem is that on Windows the tablet events are coming in bunches, not uniformly. Therefore any timing-based smoothing system will not work out of box. This patch adds a special class KisStabilizedEventsSampler, that makes the events uniform. It collects a set of events on a 50ms timeframe and then distributes it uniformly. The timeframe size should correlate with the maximum size of the delays created by the events system. On Windows it is 50ms, on Linux 15-20ms. The timeframe can be configured with "stabilizerSampleSize" config option. Ref T2414 CC:kimageshop@kde.org M +1 -0 libs/ui/CMakeLists.txt M +18 -1 libs/ui/kis_config.cc M +4 -0 libs/ui/kis_config.h M +6 -0 libs/ui/tests/CMakeLists.txt A +64 -0 libs/ui/tests/kis_stabilized_events_sampler_test.cpp [License: GPL (v2+)] A +31 -0 libs/ui/tests/kis_stabilized_events_sampler_test.h [License: GPL (v2+)] A +103 -0 libs/ui/tool/kis_stabilized_events_sampler.cpp [License: GPL (v2+)] A +90 -0 libs/ui/tool/kis_stabilized_events_sampler.h [License: GPL (v2+)] M +42 -28 libs/ui/tool/kis_tool_freehand_helper.cpp http://commits.kde.org/krita/da5496d843237daefd214a7849d2cad0f818b43b
It looks like fixing this bug generating another: https://bugs.kde.org/show_bug.cgi?id=364183
i tried eliotj's tweaks such as turning of texture buffer in display section of settings and adding "stabilizerSampleSize=20" in kritarc and I don't get the jagged bended lines as for now. i will test this config in general inking scenarios too.
Created attachment 99537 [details] attachement showing the jagged lines in krita under arch linux
I disscused on the IRC with Raghavendra kamath. Hmmm... It looks like this bug is more complicated than just Stabilizer... For me this Stabilizer fix + "stabilizerSampleSize=20" in kritarc eliminating these bended lines... Raghavendra kamath needs also turning off 'Use texture buffer' (like he described above)... For me these texture buffer dosen't do bended lines, but slow down Canvas navigation, which I reported here https://bugs.kde.org/show_bug.cgi?id=364184 1. Raghavendra kamath using Linux, I using Windows 7 - this bug doesn't be Windows only. Boud said it's true... 2. Imho: Maybe these "stabilizerSampleSize=20" should be default settings... 3. Imho: On the download page of the Krita should be some kind of warning: "If you notice some slow down in performance try turning off 'Display >> Use texture buffer".