Bug 363335 - Lock for the mirror tool.
Summary: Lock for the mirror tool.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 2.9.11
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-20 16:32 UTC by SylviaRitter
Modified: 2016-06-12 14:27 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SylviaRitter 2016-05-20 16:32:53 UTC
I often accidentally move the mirror tool while painting. 

Reproducible: Always

Steps to Reproduce:
1. Set mirror mode and try to lock it.
2.
3.
Comment 1 Halla Rempt 2016-05-21 13:56:09 UTC
Hi Silvia,

Thanks for your report. Since this is a feature request, I'm setting the bug to "wish"
Comment 2 Scott Petrovic 2016-06-06 20:20:47 UTC
I was thinking of trying to tackle this item. For a solution I was thinking of having a right-click menu on the draggable move icon.  That way it is easier to lock it right after you get done moving it.

When you right-click over the move icon the following options will show:
1. Lock (the move button will change to a lock icon and be take up less space)
2. Move to canvas center
3. Move to last position

For #3, I was thinking Krita would remember the previous location you moved the mirror tool to. These functions would be separate for the horizontal and vertical tools.
Comment 3 Scott Petrovic 2016-06-06 20:23:48 UTC
actually we probably can't put it there since the pop-up palette is also the right-click on the canvas. It might have to go where the toolbar item is at instead
Comment 4 Scott Petrovic 2016-06-07 03:03:55 UTC
I started working on this. This is kind of what I am thinking... https://www.youtube.com/watch?v=S-PBf7Qz8kQ&feature=youtu.be

There are a few other requests out there for mirror tool options, so that is what those are parts are for.
Comment 5 SylviaRitter 2016-06-07 03:53:53 UTC
Thanks for working on the mirror tool :). Looking forward to the next update.
Youtube says "This video is private." :/.
Comment 6 Scott Petrovic 2016-06-07 10:35:35 UTC
ahh sorry. I forgot to change that. Let me know if using it like this is ok...

https://www.youtube.com/watch?v=S-PBf7Qz8kQ
Comment 7 Sven Langkamp 2016-06-07 17:07:40 UTC
I also gave it a try last night, but tried to put it on the handle which also works http://imgur.com/iuFwhjU
Comment 8 Scott Petrovic 2016-06-07 18:06:31 UTC
Sven. thanks for that approach with getting that to work. While working on this last night, I also looked through some other improvements with the mirror tool. One of the requests is to "hide the mirror line" completely so it doesn't get in the way. it might be difficult to use the right-click menu if we end up hiding the entire decoration.

I didn't realize you were planning on looking at this too, or I would have wrote a comment earlier.
Comment 9 Sven Langkamp 2016-06-07 18:28:54 UTC
In case anyone want to try the other way. I will drop the patch here: https://paste.kde.org/pxnk8kw0l
Comment 10 SylviaRitter 2016-06-12 11:45:27 UTC
I like both solutions :). 
Can't wait to be able to lock the mirror axes and to be able to recenter them.
Thank you so much for improving the tool.
Comment 11 Scott Petrovic 2016-06-12 14:27:23 UTC
Git commit 5f42350f13dec2e33d4941d722938384a885b34b by Scott Petrovic.
Committed on 12/06/2016 at 14:21.
Pushed by scottpetrovic into branch 'master'.

Merge branch 'petrovic-mirrorToolUpdates'
Related: bug 323264, bug 363327


http://commits.kde.org/krita/5f42350f13dec2e33d4941d722938384a885b34b