Bug 361968 - weather widget settings: location search field default action should be "search" (instead of closing the dialog by OK)
Summary: weather widget settings: location search field default action should be "sear...
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Weather (show other bugs)
Version: 5.6.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Friedrich W. H. Kossebau
URL:
Keywords:
: 365344 365623 366828 378818 390000 395486 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-04-19 15:45 UTC by RJ
Modified: 2018-06-16 11:41 UTC (History)
10 users (show)

See Also:
Latest Commit: https://commits.kde.org/kdeplasma-addons/1634d5ed82b43d9b86efd2e0d69fa137865292ba
Version Fixed In: 5.13.0
Sentry Crash Report:

Attachments
explanation (34.61 KB, image/png)
2016-04-19 15:45 UTC, RJ 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description RJ 2016-04-19 15:45:01 UTC 
When you wrote city name in search box and hit Enter button then Option window closes. But it's wrong!

When you search the city focus should be in "Search" button

Reproducible: Always
Comment 1 RJ 2016-04-19 15:45:59 UTC 
Created attachment 98465 [details]
explanation
Comment 2 Friedrich W. H. Kossebau 2016-04-19 15:51:22 UTC 
Thanks for the report. Yes, problem known and it's annoying.
We have been looking into solving that already, but the current dialog logic sadly prevents catching the enter key there. No promises when this will be fixed, but high on the list.
Comment 3 Friedrich W. H. Kossebau 2016-07-11 11:10:51 UTC 
*** Bug 365344 has been marked as a duplicate of this bug. ***
Comment 4 Friedrich W. H. Kossebau 2016-07-14 15:28:10 UTC 
*** Bug 365623 has been marked as a duplicate of this bug. ***
Comment 5 Friedrich W. H. Kossebau 2016-08-16 13:00:51 UTC 
*** Bug 366828 has been marked as a duplicate of this bug. ***
Comment 6 Friedrich W. H. Kossebau 2018-02-07 15:34:01 UTC 
*** Bug 390000 has been marked as a duplicate of this bug. ***
Comment 7 Kai Uwe Broulik 2018-02-23 10:24:02 UTC 
*** Bug 378818 has been marked as a duplicate of this bug. ***
Comment 8 Friedrich W. H. Kossebau 2018-05-10 19:12:08 UTC 
Git commit 1634d5ed82b43d9b86efd2e0d69fa137865292ba by Friedrich W. H. Kossebau.
Committed on 10/05/2018 at 19:11.
Pushed by kossebau into branch 'master'.

[weather applet] Config: Use separate dialog for searching a new station

Prepares for having a set of stations which then could be switched
between to select the currently shown one

Having a separate dialog with completely own code also allows to
handle the Enter key as shortcut for triggering the search button.
FIXED-IN: 5.13.0

M  +37   -131  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml
C  +40   -87   applets/weather/package/contents/ui/config/WeatherStationPicker.qml [from: applets/weather/package/contents/ui/config/ConfigWeatherStation.qml - 058% similarity]
A  +115  -0    applets/weather/package/contents/ui/config/WeatherStationPickerDialog.qml     [License: GPL (v2+)]

https://commits.kde.org/kdeplasma-addons/1634d5ed82b43d9b86efd2e0d69fa137865292ba
Comment 9 Friedrich W. H. Kossebau 2018-06-16 11:41:56 UTC 
*** Bug 395486 has been marked as a duplicate of this bug. ***