Bug 359387 - Since update to KF 5.19: wrong breeze icons used for amarok and konversation in icon tasks
Summary: Since update to KF 5.19: wrong breeze icons used for amarok and konversation ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-14 12:37 UTC by Christian (Fuchs)
Modified: 2016-02-27 21:09 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of the issue (11.82 KB, image/png)
2016-02-14 12:37 UTC, Christian (Fuchs)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2016-02-14 12:37:02 UTC
Today I updated to KF 5.19
Since then in the icons only tasks plasmoids the wrong icons are used for konversation and amarok.

Other applications are fine, the correct icon seems to be used in other places (namely: the kwin icon, the pager) 

Not sure which component  is at fault here, but it would be nice if that could be fixed, monochrome icons don't look good for application icons, and if it is only two of them, they stick out rather badly.

Reproducible: Always

Steps to Reproduce:
1. Update to KF5 5.19   (tested on gentoo)
2. Use icons only task manager
3. Add konversation and amarok as starters or run them

Actual Results:  
The wrong (monochrome) icon is shown instead of the app icon

Expected Results:  
The correct (coloured) icon is shown

This is size independent, making the panel smaller or bigger (and thus the icon scaling) didn't resolve it.  I removed the plasma related files in ~/.cache, that didn't help either.
Comment 1 Christian (Fuchs) 2016-02-14 12:37:17 UTC
Created attachment 97191 [details]
Screenshot of the issue
Comment 2 Andreas Sturmlechner 2016-02-14 15:48:37 UTC
It's quite the opposite for me; The blue amarok:4 icon has always stuck in the system tray, while now it blends in with the rest. konversation:5 has been using a monochrome icon for a long time already.
Comment 3 Christian (Fuchs) 2016-02-14 15:49:24 UTC
(In reply to andreas.sturmlechner from comment #2)
> It's quite the opposite for me; The blue amarok:4 icon has always stuck in
> the system tray, while now it blends in with the rest. konversation:5 has
> been using a monochrome icon for a long time already.

Not in the system tray. In the regular task list. In the systemtray it is (and was) correct.
Comment 4 Christian (Fuchs) 2016-02-14 15:56:59 UTC
Update: the issue seems to be
/usr/share/plasma/desktoptheme/default/icons/konversation.svgz

which is taken (for whatever reason, that should be the systray icon, not the app icon) instead of /usr/share/icons/breeze/apps/<size>/konversation.svg(z) 

When I rename that file and remove the cache, the correct file is taken. 
Not sure which component leads to the wrong one being taken, but it's quite likely in frameworks 5.19, because that is the thing I updated before it broke.
Comment 5 Andreas Sturmlechner 2016-02-15 12:46:36 UTC
Indeed, same here (after restart) - I was misinterpreting your screenshot. ;)
Comment 6 Christian (Fuchs) 2016-02-17 19:14:44 UTC
I was hoping for this to be fixed with the other (systray) icon fix backported via https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f640b7c3b14c747f026e5667beddbf7def4d0549,  unfortunately this seems to be a completely unrelated issue and is still present.
Comment 7 Rex Dieter 2016-02-17 19:18:19 UTC
I think this is by design, that the plasma-themed icons will get used in preference to application-supplied ones, included as a fix for bug #353358
Comment 8 Christian (Fuchs) 2016-02-17 19:21:32 UTC
If it really is by design, then I call that faulty behaviour from an UX perspective. 

1) The icon used differs between icon tasks and everywhere else, including the pager, krunner, the application menu, kwin and the application itself. That's a massive breach of consistency. 

2) only a very limited amount of applications do provide these icons, so they also look inconsistent within icon tasks. 

If this is by design: faulty behaviour. If it isn't: faulty behaviour. So still a bug to be fixed.
Comment 9 Rex Dieter 2016-02-17 19:24:14 UTC
It is indeed a possible slippery slope when plasma themes include application icons (like konversation), when/how to use them.
Comment 10 Christian (Fuchs) 2016-02-17 19:25:50 UTC
In addition to that, the monochrome icons yet again get used in places where they weren't supposed to be used, so I'd say it even actively goes against the UX guidelines wrt icons. 

So yeah, I'd say this still needs to be fixed.
Comment 11 shyne 2016-02-18 09:07:59 UTC
Same problem here on Archlinux.
Wrong monochrome icons for amarok, ktorrent and kmail in icontasks plasmoid.
Comment 12 andreas 2016-02-18 10:04:13 UTC
the monochrome icons from the plasma theme are there cause the icons are needed in the system tray and there the app icons are monochrome.

in QT 5.17 and Plasma 5.5.1. I don't have this problem. It look like an broken Icontasks plasmoid cause the app taskbar plasmoid work.
Comment 13 Eike Hein 2016-02-18 11:56:37 UTC
Nothing has changed in Icontasks whatsoever.
Comment 14 Christian (Fuchs) 2016-02-18 11:59:41 UTC
I assume it was the changes in src/declarativeimports/core/iconitem.cpp with 5184ac94 that also caused the systray regression, mixed with how icon tasks decided which icon to take. 

As you know this logic, Eike, you hopefully can point people to the right place to fix it. 

But yes, the change came with an update of frameworks, which doesn't contain icon tasks (as I initially wrote, I think)
Comment 15 Christian (Fuchs) 2016-02-21 16:36:16 UTC
Fixed by https://phabricator.kde.org/D991,  thanks.
Comment 16 David Rosca 2016-02-22 08:47:44 UTC
Git commit 310cffc34156b094c0c68d5002ecd2d2936ac546 by David Rosca.
Committed on 22/02/2016 at 08:47.
Pushed by drosca into branch 'master'.

TaskManager: Don't use Plasma theme icons in task icon

Summary:
Also disable animation for icon in tooltip (normal Plasma tooltips
no longer have animated icon too).

Reviewers: #plasma, hein

Reviewed By: hein

Subscribers: plasma-devel

Projects: #plasma

Differential Revision: https://phabricator.kde.org/D991

M  +1    -0    applets/taskmanager/package/contents/ui/Task.qml
M  +2    -0    applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

http://commits.kde.org/plasma-desktop/310cffc34156b094c0c68d5002ecd2d2936ac546
Comment 17 Rex Dieter 2016-02-22 14:29:33 UTC
Would it be practical and possible to port to 5.5 branch please?
Comment 18 Hrvoje Senjan 2016-02-27 20:59:18 UTC
I don't think so unfortunately (at least not upstream).
usesPlasmaTheme is a new property since 5.19.0.
Comment 19 Christian (Fuchs) 2016-02-27 21:09:26 UTC
(In reply to Hrvoje Senjan from comment #18)
> I don't think so unfortunately (at least not upstream).
> usesPlasmaTheme is a new property since 5.19.0.

Yeah, it's not yet released, I applied the patch manually. I assume it will be fixed by the next bugfix release.