Bug 356600 - OSD desktop switch animation text could be bigger (and configurable)
Summary: OSD desktop switch animation text could be bigger (and configurable)
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: scripts (show other bugs)
Version: unspecified
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-13 13:53 UTC by Janet
Modified: 2018-10-28 16:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janet 2015-12-13 13:53:51 UTC
The font size used in the OSD desktop switch notification/animation has a fixed and relatively small size compared to that it should be recognized in a very short timeframe, especially on bigger displays (and very especially for people with not so good eyes). Therefore it would be helpful if the font size would make the notification a little more terse i.e. it could be bigger by default. For example I feel comforable with a font size of 32.  But as there are people with smaller displays it would be great it the font size would be configurable.

In Bug 316372 Comment 36 is mentioned a solution, a patched osd.qml file. Maybe this could get the default one? 

It would be more convenient/obvious to alter the font size via GUI (where you can choose to use the OSD and decide to use graphical or text only notification) because only if a GUI element exists most of the users probably will know that the option exists and will (dare to) use it I guess - but at least officially *having* the option would be fine.

Reproducible: Always
Comment 1 Thomas Lübking 2015-12-13 21:34:58 UTC
@Thomas P.
kcmshell5 desktop, "Switching" tab (2nd), enable "Desktop switch on-screen display", DISable "show desktop layout indicators" and switch between virtual desktops.

I don't use this indicator, yet have an opinion. Which I will state and reason after your comment ;-)
Comment 2 Thomas Lübking 2015-12-13 21:35:39 UTC
blast! sorry for re-post
----------------

@Thomas P.
kcmshell5 desktop, "Switching" tab (2nd), enable "Desktop switch on-screen display", DISable "show desktop layout indicators" and switch between virtual desktops.

I don't use this indicator, yet have an opinion. Which I will state and reason after your comment ;-)
Comment 3 Thomas Pfeiffer 2015-12-13 22:55:15 UTC
I agree that the current font size is too small to read at a glance.
It makes sense to have a common font size for all OSDs. If other OSDs have a common font size (I haven't tested, to be honest), that should be applied to this OSD as well.
Comment 4 Thomas Lübking 2015-12-14 09:47:29 UTC
> I agree that the current font size is too small to read at a glance.
Which would be my concern as well.
I don't think there's a global OSD font, but the item isn't sufficiently "in your face" (and otherwise it hardly makes sense and you'd turn it off entirely - as I personally do, I can see the current desktop in the panel)
I don't even share the size concerns given the layouted variant takes *much* more space.
Comment 5 Thomas Pfeiffer 2015-12-14 22:54:15 UTC
(In reply to Thomas Lübking from comment #4)
> > I agree that the current font size is too small to read at a glance.
> Which would be my concern as well.
> I don't think there's a global OSD font, but the item isn't sufficiently "in
> your face" (and otherwise it hardly makes sense and you'd turn it off
> entirely - as I personally do, I can see the current desktop in the panel)
> I don't even share the size concerns given the layouted variant takes *much*
> more space.

So what would you recommend?
Comment 6 Thomas Lübking 2015-12-15 08:48:48 UTC
Increase the size.
If it wasn't QML, I'd ensure the resulting size, but for QML use sth. like 32pt or 3em (iff the latter is supported) as static values.

I randomly changed the size because I wasn't happy w/ the present (and past ;-) behavior when actually fixing bug #316372 (which was about an unrelated wrong window size)
Comment 7 Thomas Pfeiffer 2015-12-15 14:35:20 UTC
Ok, so we're in agreement then, I wasn't really sure before ;)

It appears that we'll have to write a HIG for OSDs to define things like minimal font size so that we don't have to guess every time
Comment 8 Alexander Mentyu 2018-09-21 11:30:01 UTC
Reproducible on Wayland
Maybe the same font from sys tray notifications can be used?
For example when hovering over NetworkManager tray icon - popup appears with 'Networks' text in large font at the top - this font looks large enough

Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.14.80
Qt Version: 5.11.1
KDE Frameworks Version: 5.51.0
Kernel Version: 4.15.0-34-generic
Comment 9 David Edmundson 2018-10-28 16:47:14 UTC
Git commit fe07909cd8d24fa3fa32119508f90f18c7dac220 by David Edmundson.
Committed on 28/10/2018 at 16:46.
Pushed by davidedmundson into branch 'master'.

[desktopchangeosd] Sync desktop switch OSD font size to Plasma OSD font size

Summary:
Plasma's OSDs for volume/screens etc use PlasmaExtras.Heading, this
should to.

Also correct centering text to constrain the text element and align the
text within that bounding box. Previous code could have overflown in the
event of a really really long desktop name if we're resizing to the
grid.

Test Plan:
Switched desktop with OSD on
Tried with and without "show desktop layout indicators"

Reviewers: #kwin, graesslin

Reviewed By: #kwin, graesslin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16420

M  +9    -3    scripts/desktopchangeosd/contents/ui/osd.qml

https://commits.kde.org/kwin/fe07909cd8d24fa3fa32119508f90f18c7dac220