Bug 353227 - [Polish] Consider making the "Find" toolbar botton a toggle-able button.
Summary: [Polish] Consider making the "Find" toolbar botton a toggle-able button.
Status: RESOLVED DUPLICATE of bug 344617
Alias: None
Product: dolphin
Classification: Applications
Component: search (show other bugs)
Version: 16.12.2
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Scott Harvey
URL:
Keywords:
: 392796 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-27 07:59 UTC by Hussam Al-Tayeb
Modified: 2019-05-19 08:29 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Hussam Al-Tayeb 2015-09-27 07:59:54 UTC 
If I open /home/hussam and press the "Find" button in the toolbar, it opens a search bar but the button itself doesn't get into a 'pressed' state. This is ok but it is nicer in terms of polish to put the button in a pressed stated while the search bar is open. This makes the product looks more polished since users like visual feedback.
As an advantage, the [x] button in the search bar can be optionally removed if the above is implemented because I can instead toggle off the search bar. This also minimizes the buttons on the screen.
Thank you.

Reproducible: Always
Comment 1 Nate Graham 2017-09-03 05:19:45 UTC 
I rather agree.
Comment 2 Scott Harvey 2018-04-08 16:55:53 UTC 
FYI - there's also menu item `Edit -> Find (Ctrl+F)`, which should probably toggle the state of the `Find` button as well. It performs the same action (showing the Find bar).

I'm working on this and will fix the menu item as well, unless there's an objection.
Comment 3 Patrick Silva 2018-04-21 18:22:19 UTC 
*** Bug 392796 has been marked as a duplicate of this bug. ***
Comment 4 Nate Graham 2018-04-21 19:25:08 UTC 
There have been a few patches that attempted to do this, but they've all run into some issues. Heres the latest one: https://phabricator.kde.org/D12094
Comment 5 fire f. 2018-06-11 19:41:43 UTC 
I say: dump the whole FIND button and use KFIND instead via right-click: 

https://bugs.kde.org/show_bug.cgi?id=395255
Comment 6 Elvis Angelaccio 2019-05-19 08:29:22 UTC 

*** This bug has been marked as a duplicate of bug 344617 ***