Bug 344617 - “Search” should be converted to toggle button
Summary: “Search” should be converted to toggle button
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
: 353227 407682 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-02-27 08:37 UTC by Philipp A.
Modified: 2019-09-09 20:36 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In: 19.12.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp A. 2015-02-27 08:37:52 UTC
“Preview” and “Show Hidden Files” are toggle buttons.

The Filter/Search bar visibility should also be synced with their buttons.

Reproducible: Always
Comment 1 Emmanuel Pescosta 2015-02-27 08:57:56 UTC
Thanks for the feature request!
I agree with you that filter and find should be toggle buttons as well.

There is already an old patch for the "find" button: https://git.reviewboard.kde.org/r/107016/ 

Added two tasks:
https://todo.kde.org/?controller=task&action=show&task_id=966
https://todo.kde.org/?controller=task&action=show&task_id=967
Comment 2 Don Nguyen 2017-02-24 00:22:16 UTC
(In reply to Emmanuel Pescosta from comment #1)
> Thanks for the feature request!
> I agree with you that filter and find should be toggle buttons as well.
> 
> There is already an old patch for the "find" button:
> https://git.reviewboard.kde.org/r/107016/ 
> 
> Added two tasks:
> https://todo.kde.org/?controller=task&action=show&task_id=966
> https://todo.kde.org/?controller=task&action=show&task_id=967

The filter toggle patch has been committed.  I will work on making find a toggle.  The patch above seems to not show any diffs anymore.

Is todo.kde.org dead?  I can't access it right now.
Comment 3 Don Nguyen 2017-03-12 09:42:21 UTC
The committed filter toggle patch has been reverted.  https://git.reviewboard.kde.org/r/129662/
I discarded my find toggle patch submission because I think it'll be opposed for the same reason.
https://git.reviewboard.kde.org/r/129972/
Comment 4 Nate Graham 2018-02-02 15:31:30 UTC
Another patch for this: https://phabricator.kde.org/D10246

User interest in this change is strong.
Comment 5 Elvis Angelaccio 2019-05-19 08:29:22 UTC
*** Bug 353227 has been marked as a duplicate of this bug. ***
Comment 6 Elvis Angelaccio 2019-05-19 08:29:32 UTC
*** Bug 407682 has been marked as a duplicate of this bug. ***
Comment 7 Elvis Angelaccio 2019-09-01 20:07:52 UTC
Git commit 3a7586907ed834fb3c09d47e047da305a25374a2 by Elvis Angelaccio, on behalf of Ismael Asensio.
Committed on 01/09/2019 at 19:59.
Pushed by elvisangelaccio into branch 'master'.

[dolphin] Add an action to toggle the searchbar

Summary:
Make search action toggle the searchbar instead of just launching it.

The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar.
This behavior in inconsistent with other dolphin actions which toggle panels or tools.

BEFORE:
{F7256652}

AFTER:
{F7256862}
FIXED-IN: 19.12.0
Closes T8473

Depends on D23075

Test Plan:
- Enable the search mode: the searchbar appears and the toolbar button gets checked
- Press the search button again, and it goes back to normal mode.
- The search button state is coherent with the searchbox
- Coherence is kept when changing to a split view or different tab
- Shorcut <Ctrl-F> does not close the searchbar, but moves the focus to it.

Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio

Reviewed By: ngraham, #vdg

Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel

Tags: #dolphin

Maniphest Tasks: T8473

Differential Revision: https://phabricator.kde.org/D23232

M  +26   -0    src/dolphinmainwindow.cpp
M  +3    -0    src/dolphinmainwindow.h
M  +3    -3    src/dolphinui.rc
M  +2    -0    src/dolphinviewcontainer.cpp
M  +12   -5    src/dolphinviewcontainer.h

https://commits.kde.org/dolphin/3a7586907ed834fb3c09d47e047da305a25374a2
Comment 8 Elvis Angelaccio 2019-09-01 20:11:15 UTC
Renaming the bug report. We are not going to make the filter button a toggle, because there is a clash with the CTRL+I shortcut that's not easy to fix. Since this button is not visible on the default toolbar, it's not worth the effort.
Comment 9 pmargeti34 2019-09-08 15:12:57 UTC
New toggle search is awesome, I suggest you also make ctrl+f default to it instead of old search. Or is old search getting removed?
Comment 10 Nate Graham 2019-09-09 15:20:14 UTC
(In reply to pmargeti34 from comment #9)
> New toggle search is awesome, I suggest you also make ctrl+f default to it
> instead of old search. Or is old search getting removed?

That was deliberate, because we are under the impression that there are people who like keeping the search panel open and simply focusing it with ctrl+f.

If this does not describe you can re-map the keys in Settings > Keyboard Shortcuts.
Comment 11 pmargeti34 2019-09-09 20:36:46 UTC
That's a good point. My use case is search oneshots and toggling it off and I did rebind the hotkey to the toggle. Thanks! Great work on this! Hope the filter bar can receive same love in the future too ;)