Bug 345347 - "Add to places" action doesn't work properly from context menu in dolphin
Summary: "Add to places" action doesn't work properly from context menu in dolphin
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: places (show other bugs)
Version: 16.12.2
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
: 347519 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-03-19 23:38 UTC by Prasad Murthy
Modified: 2015-05-25 09:55 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 15.04


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Prasad Murthy 2015-03-19 23:38:31 UTC
Dolphin Version 14.12.3
Using KDE Development Platform 4.14.6
Kate is using Frameworks Version 5.7.0

Distributor ID: Ubuntu
Description:    Ubuntu Vivid Vervet (development branch)
Release:        15.04
Codename:       vivid

uname -r
3.19.0-9-generic

Tested distro: kubuntu 15.10 daily build on 19 mar 2015
When trying to add a folder to places in dolphin from the context menu "Add to places", the folder gets added to places, but the change is not visible. When you add a folder to places using drag and drop method the change along with the previously added folder which was not visible become visible/updated. 

Reproducible: Always

Steps to Reproduce:
1. Add a folder to places using the dolphin context menu action "Add to places"
2. There will be no visual change. Add a folder to places by drag and drop method to the places
3. The cumulative change will be visible now

Actual Results:  
The added folder using the context menu is not shown in the places 

Expected Results:  
The added folder using the context menu should be visible instantly

From the debug message I can see that a the folder containg the .xbel file is added to the kdirwatch list and find the folders added. The problem seems to be with the dolphin's context menu action.
Comment 1 Prasad Murthy 2015-03-19 23:48:37 UTC
Checked with the daily build of  SUSE on 20 mar 2015

Dolphin version 14.12.3
Using KDE Development Platform 4.14.6

Distro details
Distributor ID: openSUSE project
Description: openSUSE 20150316 (Tumbleweed) (i586)
Release: 20150316
Comment 2 soee 2015-03-19 23:54:14 UTC
I can confirm this issue on latest Kubuntu Vivid.
Comment 3 Prasad Murthy 2015-03-19 23:57:54 UTC
Bug marked as Confirmed based on comment 2
Comment 4 Emmanuel Pescosta 2015-03-20 07:47:50 UTC
Thanks for the bug report!

*** This bug has been marked as a duplicate of bug 345174 ***
Comment 5 Emmanuel Pescosta 2015-03-20 10:52:20 UTC
Ok I was wrong, this bug isn't a duplicate. The problem is a missing saveBookmarks call.
Comment 6 Emmanuel Pescosta 2015-03-20 11:08:33 UTC
Review-Request: https://git.reviewboard.kde.org/r/123080/
Comment 7 Emmanuel Pescosta 2015-03-21 16:29:47 UTC
Git commit 89f912a3c7e8b88e07bfbe9774999dc5d103f122 by Emmanuel Pescosta.
Committed on 20/03/2015 at 10:56.
Pushed by emmanuelp into branch 'Applications/15.04'.

Save bookmarks when adding them via the context menu.

FIXED-IN: 15.04
REVIEW: 123080

M  +2    -0    dolphin/src/dolphincontextmenu.cpp

http://commits.kde.org/kde-baseapps/89f912a3c7e8b88e07bfbe9774999dc5d103f122
Comment 8 Emmanuel Pescosta 2015-03-21 16:40:34 UTC
Git commit fba5dd58a55e191a3368cc85735826c2b9e18a8b by Emmanuel Pescosta.
Committed on 21/03/2015 at 16:39.
Pushed by emmanuelp into branch 'master'.

Save bookmarks when adding them via the context menu.
REVIEW: 123080

M  +2    -0    src/dolphincontextmenu.cpp

http://commits.kde.org/dolphin/fba5dd58a55e191a3368cc85735826c2b9e18a8b
Comment 9 Peter Chibunna 2015-05-04 14:09:32 UTC
I can confirm this bug. However it's not only that the "saveBookmarks" is not being called when "Add to Places" context menu is clicked, when you add a bookmark from the Places bar directly by right clicking and selecting "Add Entry", the same effects are observed. 

Summary: The places bookmarks cannot be updated by a user.
Comment 10 Frank Reininghaus 2015-05-10 15:33:41 UTC
*** Bug 347519 has been marked as a duplicate of this bug. ***
Comment 11 André Verwijs 2015-05-25 09:55:12 UTC
- Linux 3.16.7-21-desktop
- openSUSE 13.2 (Harlequin) (x86_64)
- KDE:  4.14.6
- Dolphin 14.12.3-16.5


Same problem here,  "/local/share/user-places.xbel"  is not being updated.. (witch saves "places" i think)  

or merge  git update with OpenSUSE package.... 

André