Bug 341620 - JJ: Dialogs are too big
Summary: JJ: Dialogs are too big
Status: RESOLVED LATER
Alias: None
Product: krita
Classification: Applications
Component: Usability (other bugs)
Version First Reported In: 2.9 Beta
Platform: Ubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: junior-jobs
: 343696 (view as bug list)
Depends on: 344572
Blocks:
  Show dependency treegraph
 
Reported: 2014-12-07 05:51 UTC by Leslie Viljoen
Modified: 2016-03-22 12:52 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Patch file to address some of the dialogue size issues (1.15 KB, patch)
2014-12-18 20:28 UTC, peat
Details
Updated, removed max width on brush design widget (1.15 KB, patch)
2014-12-18 20:53 UTC, peat
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Leslie Viljoen 2014-12-07 05:51:12 UTC
Some of krita's dialogs are bigger than 768 vertical pixels, which is a common resolution for laptops and some screen-tablets. It would be great if they could fit on the screen.

Dialogs that are big:
1. The new image dialog
2. Edit-brush-settings
3. Filter>Artistic>Index colors
4. Preferences

There are probably others but these are the most obvious ones.


Reproducible: Always

Steps to Reproduce:
Open the relevant dialog.

Actual Results:  
Dialog too big to fit on screen.

Expected Results:  
Dialog fits on screen.

The work-around for me is to use alt-left-click to drag the window up, which requires switching from my tablet to the laptop keyboard and mouse. IME most people don't know about alt-left-click for dragging windows.
Comment 1 wolthera 2014-12-15 19:08:24 UTC
Yeah, the index-colour specifically is a bit large.

I'm turning this into a junior job, as wrangling with QT's interface is a good way to get started :)
Comment 2 peat 2014-12-18 17:13:55 UTC
Ok I'm going to have a go at trying to fix as much of this is possible. It might be that certain widgets just wont shorten without squewing them badly
Comment 3 peat 2014-12-18 20:28:36 UTC
Created attachment 90041 [details]
Patch file to address some of the dialogue size issues

Of the 4 Dialogues mentioned in the request the following is the status

1. The new image dialog - I have reduced this slightly and tried to lock it to a max high of 768. Setting my desktop tp 1024*768 for testing and the dialogue appears completely on the desktop

2. Edit-brush-settings - Same as 1. above

3. Filter>Artistic>Index colors - I don't think it is possible to shrink this dialogue any further, we could possibly redesign it making the options in a matrix form rather than a list form it currently is set to

4. Preferences - Not completely sure what this is do you mean - Settings -> Configure Krita ?
Comment 4 sssstaticccc 2014-12-18 20:50:14 UTC
I use a netbook and it works surprisingly great but the resolution is 1024 x 600.

Thats even lower than what you guys are testing for in this bug but I havent had a real issue yet, things are still just small enough in most cases that I can click the partially visible button (so they usually clip off screen still...but if i can click it right? :) ).

I wouldnt reject some love for this resolution though :)

I am however having some real trouble opening the brush browser. 
It sees theres not enough space to open down and tries to open up instead..
90% off screen lol.

I took a screenshot.        Attaching it here vvvv

http://i.imgur.com/6szIdWK.png



Also, it might be seeing 1024x590 or so because of my autohiding system bar at the top, in case you were thinking of making a hard fix for 600.
Comment 5 peat 2014-12-18 20:53:36 UTC
Created attachment 90043 [details]
Updated, removed max width on brush design widget

Testing by increasing the system font to 16px shows an issue with the max width setting, attached an update removing this constraint
Comment 6 Leslie Viljoen 2014-12-18 22:02:09 UTC
(In reply to peat from comment #3)
> Created attachment 90041 [details]
> Patch file to address some of the dialogue size issues
> 
> Of the 4 Dialogues mentioned in the request the following is the status
> 
> 1. The new image dialog - I have reduced this slightly and tried to lock it
> to a max high of 768. Setting my desktop tp 1024*768 for testing and the
> dialogue appears completely on the desktop
> 
> 2. Edit-brush-settings - Same as 1. above
> 
> 3. Filter>Artistic>Index colors - I don't think it is possible to shrink
> this dialogue any further, we could possibly redesign it making the options
> in a matrix form rather than a list form it currently is set to
> 
> 4. Preferences - Not completely sure what this is do you mean - Settings ->
> Configure Krita ?

Yes, that opens a dialog called "Preferences".

Now that I read below, I've set my system fonts to 10 pt instead of 11 and Preferences comes in at 770px tall. Sorry, I guess that's an obvious thing when you think about it - increasing font sizes will make dialogs bigger! If most people use 10pt this too-large-dialogs problem is less of a problem. Even the file->new dialog almost fits with 10pt.

Still, it probably is a good idea to have a *little* breathing room.
Comment 7 Halla Rempt 2015-02-02 14:08:22 UTC
*** Bug 343696 has been marked as a duplicate of this bug. ***
Comment 8 Nik Prodanov 2015-02-02 15:57:50 UTC
Apart from reorganizing and cleaning up the brush menus etc, perhaps it would also be nice to have a DPI setting the way it's done in Blender? It allows the user to set the correct scaling for fonts and icons even on very low resolution screens.
Comment 9 wolthera 2015-02-02 16:36:24 UTC
(In reply to Nik Prodanov from comment #8)
> Apart from reorganizing and cleaning up the brush menus etc, perhaps it
> would also be nice to have a DPI setting the way it's done in Blender? It
> allows the user to set the correct scaling for fonts and icons even on very
> low resolution screens.

This is not as easy as it seems to you. We will at least first need upgrade to QT5, which happens in 3.0, and even after that it'll take a significant amount of time. It's outside the scope of a junior job as well.
Comment 10 Halla Rempt 2016-03-22 12:52:40 UTC
The startup dialog is fixed now, for the brush editor a workaround exists (detach and hide the scratchpad). There is work going on redesigning the brush editor, but that's something that will take more time.