Bug 340751 - Color Sliders docker - two sliders jump around randomly while moving one slider
Summary: Color Sliders docker - two sliders jump around randomly while moving one slider
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-08 02:52 UTC by JayJay
Modified: 2016-09-27 12:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description JayJay 2014-11-08 02:52:30 UTC
When one slider is changed, the other two will move around randomly, changing the color unpredictably.

Reproducible: Always

Steps to Reproduce:
1. Select something  in HUE slider
2. Change either SAT or VALUE
3.
Comment 1 JayJay 2014-11-11 05:35:49 UTC
Similar behaviour also exists in the Specific Color Selector, Lab 16-bit slider. Altho to a lesser degree. Difficult to select an accurate color.
Comment 2 wolthera 2014-12-10 17:57:01 UTC
Yes, this is a precision issue... though I don't know why it happens in the specific colour selector as well...

Maybe it's because of the way how they link with the little number input next to them?
*will experiment*
Comment 3 wolthera 2014-12-12 17:06:56 UTC
Git commit b94b0bcfdd1da4c315ef41945d58e01a30816767 by Wolthera van Hovell.
Committed on 12/12/2014 at 17:06.
Pushed by woltherav into branch 'calligra/2.9'.

Decrease Color Slider Dancing further.

And the quest continues.

Errors still show up on darker colours, in particular blue causes the
saturation to go up. Makes perfect sense algorithm wise(there's less
possible colours at those lightnesses, so more chance at mistakes), but
not usuability wise and it's a pain to get rid of it.

Again to fix these errors I either jack up the precision of the
algorithms to long double, or I rewrite the whole color slider docker to
be more like the advanced colour selector. But both are very complex to
do.
Related: bug 313787

M  +105  -40   krita/plugins/extensions/dockers/colorslider/kis_color_slider_input.cpp
M  +4    -0    krita/plugins/extensions/dockers/colorslider/kis_color_slider_input.h
M  +39   -1    krita/plugins/extensions/dockers/colorslider/kis_color_slider_widget.cpp
M  +2    -0    krita/plugins/extensions/dockers/colorslider/kis_color_slider_widget.h

http://commits.kde.org/calligra/b94b0bcfdd1da4c315ef41945d58e01a30816767
Comment 4 mvowada 2015-01-29 15:44:39 UTC
Hi. I don't know if someone has worked on this, but it seems to me there has been a step ahead in the last month, to me outcomes seem more consistent now. Not 100% reliable yet, though.
Comment 5 wolthera 2015-01-29 16:34:34 UTC
(In reply to mvowada from comment #4)
> Hi. I don't know if someone has worked on this, but it seems to me there has
> been a step ahead in the last month, to me outcomes seem more consistent
> now. Not 100% reliable yet, though.

Yes, as you can see above, that is the last change.
The problem is that these need to be rewritten completely, and in general there's a bug with the design of the colour selectors that'll require a rewrite.
Comment 6 mvowada 2015-01-29 17:56:14 UTC
Probably it's due to an outdated version that I was using after the change then. Thank you
Comment 7 xenustehg 2016-09-27 12:50:29 UTC
I want to point out certain bugs that also happen in color slider "dancing" behaviour:
Luma/Lightness/Value/Intensity sliders acts strange when a user tries to change them with mouse at near zero position.
With certain values of other two sliders, the Hue slider cannot be set on 360 it drops to 0 instantly.