Created attachment 76670 [details] HSV color picker with sliders Please add support for a HSV color picker with sliders for the advanced color selector or as a standalone docker. This is quite useful for digital painting. This way, choosing a precise tone of color is an easier task and more precise. "Mockup" attached. Thanks.
Good idea to make it part of the Advanced Color Selector. ( and nice mockup ) Additional thought : This panel extension should be optional, and activated via the top-left wrench ( to configure the Advanced Color Selector ). An optional idea to perfect it : proposing on a new tab 'Sliders' a series of checkboxes : ☑ Hue ☑ Saturation ☐ Value ☑ Luminance --- ☐ Red ☐ Green ☐ Blue --- ☐ Cyan ☐ Magenta ☐ Yellow ☐ Black ( I had the idea watching this screenshot of SAI Tools http://www.tigerknight.com/stuff/20111013-4.jpg proposing HSV+RGB , and here I would probably like playing with HSL , or only L , or sometime CMYK approximation on a RGB picture, ...etc.... )
Ack, it would be a nice addition.
This would be an amazing feature.
I think there should also be an HSV/HSL mode in the Specific Color Selector - it's missing currently. SAI's color picking sliders are excellent, another UI hint that should be taken from them is the larger indicator arrows - in Krita they are so invisible that i'm sure most users aren't aware they exist. I like the way this is done in Inkscape (http://tavmjong.free.fr/INKSCAPE/MANUAL_v14/images/DIALOGS/Dialog_FillStroke_HSL.png) The arrows are black and face inwards so there is no way to mistake the position.
I recently added this, but there's still a thing that needs to be done: increase the precision of the colour algorithms. It dances a little now. Other than that, get the color slider docker from the new development builds, and check the colour selector preferences to add and remove sliders from it.
Git commit b94b0bcfdd1da4c315ef41945d58e01a30816767 by Wolthera van Hovell. Committed on 12/12/2014 at 17:06. Pushed by woltherav into branch 'calligra/2.9'. Decrease Color Slider Dancing further. And the quest continues. Errors still show up on darker colours, in particular blue causes the saturation to go up. Makes perfect sense algorithm wise(there's less possible colours at those lightnesses, so more chance at mistakes), but not usuability wise and it's a pain to get rid of it. Again to fix these errors I either jack up the precision of the algorithms to long double, or I rewrite the whole color slider docker to be more like the advanced colour selector. But both are very complex to do. Related: bug 340751 M +105 -40 krita/plugins/extensions/dockers/colorslider/kis_color_slider_input.cpp M +4 -0 krita/plugins/extensions/dockers/colorslider/kis_color_slider_input.h M +39 -1 krita/plugins/extensions/dockers/colorslider/kis_color_slider_widget.cpp M +2 -0 krita/plugins/extensions/dockers/colorslider/kis_color_slider_widget.h http://commits.kde.org/calligra/b94b0bcfdd1da4c315ef41945d58e01a30816767
whoops, didn't realise that would close it.
@wolthera Great but I think KisHSXColorSliderInput and KisColorSliderWidget are full of copy-paste code. Do you think it could be improved? The recent patch shows this too, otherwise it would be like a few lines long only.
Yes and no. Thing is, the sliders support four different models, and for each of those the code can be very extremely specific. If you look carefully, there's like a single line that is different per block of 'copy-pasted' code. The advanced colour selector suffers from the same issue. A couple of case statements can be simplified, but I think there's less than you'd intuitively would think looking at them :/