Bug 339435 - lock-logout applet icons have too much padding
Summary: lock-logout applet icons have too much padding
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-26 16:56 UTC by Antonio Rojas
Modified: 2015-02-17 21:46 UTC (History)
3 users (show)

See Also:
Latest Commit: http://commits.kde.org/plasma-workspace/5c1cb198d69bb06e82c9fb5feb0ebbeec162230c
Version Fixed In: 5.3.0

Attachments
Screenshot in current git (6.35 KB, image/png)
2014-09-26 16:57 UTC, Antonio Rojas 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2014-09-26 16:56:30 UTC 
The icons in the lock-logout applet have too much padding in git master, which makes them almost invisible if they are stacked in two rows.

Reproducible: Always
Comment 1 Antonio Rojas 2014-09-26 16:57:34 UTC 
Created attachment 88852 [details]
Screenshot in current git

Compare the size in plasma 5.0 here https://bugsfiles.kde.org/attachment.cgi?id=86241
Comment 2 Bhushan Shah 2014-09-27 13:14:34 UTC 
I can confirm
Comment 3 Kai Uwe Broulik 2014-10-16 08:58:41 UTC 
Isn't the applet supposed to layout its items horizontally when it's in a horizontal panel?
Comment 4 Antonio Rojas 2014-10-17 07:00:25 UTC 
Actually making the panel a little bit smaller rearranges the buttons in one row, and making it a little bit larger increases the button size and this issue disappears. So it's only in a very small range of panel heights that this happens.
Comment 5 Antonio Rojas 2015-01-15 10:03:34 UTC 
This issue became much worse in 5.2, now you really have to make the panel huge to make the buttons have a reasonable size
Comment 6 Martin Klapetek 2015-01-16 17:47:07 UTC 
I don't know if this got fixed or what, but it looks perfectly fine here (today's git).

Can anyone else please confirm?
Comment 7 Antonio Rojas 2015-01-29 13:21:09 UTC 
No changes in 5.2 final
Comment 8 Kai Uwe Broulik 2015-02-17 21:46:30 UTC 
Git commit 5c1cb198d69bb06e82c9fb5feb0ebbeec162230c by Kai Uwe Broulik.
Committed on 17/02/2015 at 21:45.
Pushed by broulik into branch 'master'.

Replace checkLayout() function by declarative bindings and set a sensible minimum size
Related: bug 337318
FIXED-IN: 5.3.0
REVIEW: 122596

M  +30   -47   applets/lock_logout/contents/ui/lockout.qml

http://commits.kde.org/plasma-workspace/5c1cb198d69bb06e82c9fb5feb0ebbeec162230c