Bug 337318 - lock/logout applet doesn't resize when adding/removing buttons
Summary: lock/logout applet doesn't resize when adding/removing buttons
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: unspecified Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 11:50 UTC by Antonio Rojas
Modified: 2015-02-17 21:46 UTC (History)
2 users (show)

See Also:
Latest Commit: http://commits.kde.org/plasma-workspace/5c1cb198d69bb06e82c9fb5feb0ebbeec162230c
Version Fixed In: 5.3.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2014-07-10 11:50:21 UTC 
The applet should resize when adding or removing buttons. Now it only resizes after restarting plasmashell.

Reproducible: Always
Comment 1 David Edmundson 2014-08-24 03:05:13 UTC 
Confirmed.

Looks to be changing a binding to a direct assignment (=) in the checkLayout function.

Adding Qt.binding() will fix it, but ideally I want to kill the checkLayout function it's not very declarative
Comment 2 Kai Uwe Broulik 2015-02-17 21:46:30 UTC 
Git commit 5c1cb198d69bb06e82c9fb5feb0ebbeec162230c by Kai Uwe Broulik.
Committed on 17/02/2015 at 21:45.
Pushed by broulik into branch 'master'.

Replace checkLayout() function by declarative bindings and set a sensible minimum size
Related: bug 339435
FIXED-IN: 5.3.0
REVIEW: 122596

M  +30   -47   applets/lock_logout/contents/ui/lockout.qml

http://commits.kde.org/plasma-workspace/5c1cb198d69bb06e82c9fb5feb0ebbeec162230c