Bug 338612 - the icons in the toolbars show in wrong order, "Save" not shown during practice
Summary: the icons in the toolbars show in wrong order, "Save" not shown during practice
Status: RESOLVED WORKSFORME
Alias: None
Product: parley
Classification: Applications
Component: general (other bugs)
Version First Reported In: 1.0.0
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: parley bug tracker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-28 07:13 UTC by Ansa
Modified: 2023-02-01 05:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Quit should come at the end but does not (194.09 KB, image/png)
2014-08-28 07:13 UTC, Ansa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ansa 2014-08-28 07:13:42 UTC
Created attachment 88463 [details]
Quit should come at the end but does not

This happens in the "new parley" from the Kubuntu from the Kubuntu-ppa/backport repository

The appearance of the toolbar does not correspond to the settings in the "configure toolbars" dialog. The <Merge> only merges in the first item of the subsetting, not all items as expected.

In the Practice Mode, no "Save" icon is shown in the Toolbar (although it should). There is even no "Save" icon in the File menu. Is this intended?



My settings are:
Editor Toolbar <parley>            Dashboard-Save-<Merge>-Quit
Practice Toolbar <parley>          Save-Quit
Statistics Toolbar <parley>        Dashboard-Save-<Merge>-Quit
Practice Summary Toolbar <parley>  Dashboard-Save-<Merge>-Quit
Practice Toolbar <practice>        Full Screen-Stop Practice
Practice Summary Toolbar <practicesummary>  Editor-Practice Overview-Export results

Icons shown:
Practice overview     Dashboard-Save-Editor-Quit-Configure Practice-Start Practice
   Quit should come at the end
Practice summary      Dashboard-Save-Editor-Quit-Practice Overview-Export results
   Quit should be at the end
Practice mode         Quit-Full Screen-Stop Practice
   Where is Save?
Comment 1 Christoph Feck 2014-09-14 10:32:19 UTC
Related to bug 64754 ?
Comment 2 Inge Wallin 2014-09-14 22:36:36 UTC
Two things:

1. You have opened the settings for the Editor Toolbar but you are showing the Practice Summary Toolbar.  This seems like a likely source of this error.
2. It might be that there are actually two toolbars in the window. At least there seems to be when I open the practice summary window.

But my guess is number 1.  Can you check if the same bug remains if you change the settings for the Practice Summary Toolbar too?
Comment 3 Ansa 2014-09-16 21:47:25 UTC
Sorry for the confusing image. Parley "Configure Toolbar" settings are confusing, too; I try to make this post clearer, but as a result, it is longer than I like. There is a summary at the end. I have checked the behaviour in the current master branch.

In the "Configure Toolbar" dialogue (in the "Settings" menu), there are always five subdialogues, four of them identical across all "Parley states" (Editor, Practice Overview, Practice, Practice Summary), marked with <parley>. The fifth is always only relevant to the current state/mode of parley, for example if parley is currently showing the editor, the fifth submenu is "Editor <editor>". The fifth option does not depend on which Toolbar is actually shown, but only on the actual state of parley. Parley has some kind of default settings as to which toolbars are shown in which mode:

Editor                                                    -> Editor Toolbar
Practice Overview (before practice)  -> Statistics Toolbar
Practice                                                 -> Practice Toolbar
Practice Summary (after practice)     -> Practice Toolbar AND Practice Summary Toolbar

While the user can change which toolbar is shown, the next time they re-enter the same state/mode, the toolbars shown are reset to the defaults. BUG 1: in Practice Summary state/mode, only the Practice Summary Toolbar should be shown.

My settings are as in the previous post. I write them separatel for each parley state, with the actual result.

--->
Editor Toolbar <parley>     Dashboard-Save-<Merge>-Quit 
Editor Toolbar <editor>     Copy-Paste-New Unit-Add New Entry-Practice
Resulting Editor Toolbar is as expected, the <editor> part is merged into the <parley> part as a whole at the spot specified by <Merge>:
                                              Dashboard-Save-Copy-Paste-New Unit-Add New Entry-Practice-Quit

--->
The Statistics Toolbar (which is a confusing name, because this is now called "Practice overview"; it is the screen with the settings for an upcoming practice session):
Statistics Toolbar <parley>      Dashboard-Save-<Merge>-Quit 
Statistics Toolbar <statistics>  Editor-Configure Practice-Start Practice
Actual results - BUG 2: only the first item of <practicesummary> appears at the spot specified by <Merge>, the others at the end.
                                                   Dashboard-Save-Editor-Quit-Configure Practice-Start Pracice

--->
Practice Toolbar <parley>     Save-<Merge>-Quit 
Practice Toolbar <practice> Full Screen-Stop Practice 
Actual results - BUG3: this time, Save is missing completely, and the order is wrong:
                                                Quit-Full Screen-Stop Practice

So I have tried to set "Practice Toolbar <parley>" to the same settings as the other three <parley> submenus, just in case:
Practice Toolbar <parley>     Dashboard-Save-<Merge>-Quit 
Practice Toolbar <practice>  Full Screen-Stop Practice 
This time, both Save and Dashboard are missing, and the order is wrong:
                                                 Quit-Full Screen-Stop Practice

The Quit is at the beginning when the practice is started with the settings already specified as given (which has to be done during a previous practice). However, when the Configure Toolbars dialogue is started, the "Practice Toolbar <parley>" submenu is chosen and the Dashboard icon is either added or removed, the Quit miraculously moves to its correct position after the other icons. This is BUG4: the effect of the settings is not constant.



---> Now for Practice Summary (the screen after practice, with percentages answered correctly etc.)
Practice Summary Toolbar <parley>                    Dashboard-Save-<Merge>-Quit 
Practice Summary Toolbar <practicesummary> Editor-Practice Overview-Export results 
Actual results (just the Practice Summary Toolbar) - BUG2 again: only the first item of <practicesummary> appears at the spot specified by <Merge>, the others at the end:
                                                                                  Dashboard-Save-Editor-Quit-Practice Overview-Export results



SUMMARY:
BUG 0: the Configure Toolbar dialogue is not the same within all parley states/modes
BUG 1: both the "Practice Toolbar" and "Practice Summary Toolbar" are shown for the Practice Summary mode
BUG 2: in the Practice Overview (Statistics Toolbar) and Practice Summary modes, <Merge> only affects the first item of the mode-specific part of settings.
BUG 3: In the Practice Mode, settings to show "Save" and "Dashboard" are ignored. Items are also merged to a different spot than specified by <Merge>.
BUG 4: The effect of the settings is different if they are already specified when a given state/mode is entered and when they are specified while the state is already there.
Comment 4 Inge Wallin 2014-09-16 23:41:22 UTC
Whoa!  Let me just answer right now that I will look at this closer at some point but right now I don't have the opportunity due to some other issues. But it does seem that you have looked at it really thoroughly.
Comment 5 Andrew Crouthamel 2018-11-12 02:44:43 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Andrew Crouthamel 2018-11-21 04:20:36 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Justin Zobel 2023-01-02 07:43:51 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 8 Bug Janitor Service 2023-01-17 05:16:49 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Bug Janitor Service 2023-02-01 05:06:03 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!