Bug 337033 - Video playback on panel doesnt work
Summary: Video playback on panel doesnt work
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-04 08:27 UTC by Filippe
Modified: 2014-10-24 06:27 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.14.3


Attachments
dolphin's panel (52.58 KB, image/png)
2014-07-04 08:29 UTC, Filippe
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Filippe 2014-07-04 08:27:41 UTC
After clicking "play" on dolphin's information panel, a black square appears under thumbnail and playback doesn't start.
Tried gstreamer and vlc phonon backends.

Reproducible: Always
Comment 1 Filippe 2014-07-04 08:29:25 UTC
Created attachment 87533 [details]
dolphin's panel
Comment 2 Frank Reininghaus 2014-07-04 12:20:25 UTC
Thanks for the bug report.

(In reply to comment #0)
> Tried gstreamer and vlc phonon backends.

Thanks for the info. In any case, it seems more likely that it is a Phonon issue and not a bug in Dolphin.
Comment 3 Filippe 2014-07-04 12:42:49 UTC
(In reply to comment #2)
> Thanks for the bug report.
> 
> (In reply to comment #0)
> > Tried gstreamer and vlc phonon backends.
> 
> Thanks for the info. In any case, it seems more likely that it is a Phonon
> issue and not a bug in Dolphin.

Is it? Embedded player in Ktorrent, for example, works fine.
Comment 4 Frank Reininghaus 2014-07-04 13:31:15 UTC
(In reply to comment #3)
> Is it? Embedded player in Ktorrent, for example, works fine.

I cannot comment on KTorrent, but all that Dolphin does after pressing the "Play" button is to create a Phonon::MediaObject and call some of its methods, see the function PhononWidget::play() in

http://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=a36ada180126c6d84452aa43720d59c94b9ef82a&hb=1f69714a23a222b5edabfdad9896e58a4818729e&f=dolphin%2Fsrc%2Fpanels%2Finformation%2Fphononwidget.cpp

If  the Phonon developers see anything that we do wrong there, please let us know.
Comment 5 Harald Sitter 2014-07-04 18:43:14 UTC
First off I cannot reproduce the GStreamer problem. If appropriate codecs are available there is no reason for it not to play anything, and the 4.7 series definitely does. Please file a new report for that against the phonon-backend-gstreamer product. Ideally with debugging enabled [1].

VLC is another story entirely though. The problem is that dolphin tries to be smart and VLC tires to be smart as well, which makes for a not so smart smartness clash.

Dolphin only creates a videowidget when it received the hasVideo(true) signal, this however never gets sent because VLC quite simply will not create a video output if it doesn't have an output target (i.e. widget) and phonon-vlc cannot tell whether there is video unless VLC creates a video output.

So, the correct solution is to always have a video widget (it could be hidden or below the preview image until hasVideo(true) is sent, it just needs to exist).

This is not the best possible thing ever but until VLC grows support for actual content introspection it is the best option I can offer unfortunately.

[1] http://techbase.kde.org/Development/Tutorials/Debugging/Phonon
Comment 6 Filippe 2014-07-05 09:48:04 UTC
(In reply to comment #5)
> Please file a new report for that against the
> phonon-backend-gstreamer product. Ideally with debugging enabled [1].
Done https://bugs.kde.org/show_bug.cgi?id=337107.
Comment 7 Emmanuel Pescosta 2014-10-24 06:27:12 UTC
Git commit 3866c88ce9f4dd509752ba08424a65570fcf4b9d by Emmanuel Pescosta, on behalf of Andrey Bondrov.
Committed on 24/10/2014 at 06:21.
Pushed by emmanuelp into branch 'KDE/4.14'.

Fix the information panel video player in Dolphin.

Patch from ROSA Linux.
Related: bug 337107, bug 334924, bug 339882
REVIEW: 120745
FIXED-IN: 4.14.3

M  +7    -9    dolphin/src/panels/information/phononwidget.cpp

http://commits.kde.org/kde-baseapps/3866c88ce9f4dd509752ba08424a65570fcf4b9d