Bug 335861 - Clock in new lock screen should enforce monotype font
Summary: Clock in new lock screen should enforce monotype font
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (other bugs)
Version First Reported In: master
Platform: unspecified Linux
: NOR normal
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-06 06:37 UTC by Martin Flöser
Modified: 2014-06-18 14:52 UTC (History)
6 users (show)

See Also:
Latest Commit: http://commits.kde.org/plasma-workspace/94088588b31abfbb9463006203d05842eab4664f
Version Fixed In:
Sentry Crash Report:
kde: VisualDesign+

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Flöser 2014-06-06 06:37:54 UTC 
The new lock screen in the look'n'feel package has a digital clock and it is "dancing". This looks to me like it's not using a monotype font.

Reproducible: Always

Steps to Reproduce:
1. Lock screen
Actual Results:  
The clock is moving to the left and right depending on how large the digits are

Expected Results:  
The clock doesn't change size
Comment 1 Aleix Pol 2014-06-06 08:19:01 UTC 
Wouldn't it be better just to not show the seconds? or show them separately nearby maybe with a smaller font?
Comment 2 Martin Flöser 2014-06-06 08:23:58 UTC 
(In reply to comment #1)
> Wouldn't it be better just to not show the seconds? or show them separately
> nearby maybe with a smaller font?

the problem will also be noticeable with minutes and hours. Just less prominent. But yes, I would get rid of the seconds, they are kind of distracting.
Comment 3 Christoph Feck 2014-06-06 12:37:27 UTC 
Is this bug 314140? Is it still valid?
Comment 4 Aleix Pol 2014-06-06 12:42:33 UTC 
Oh! well, maybe we should enforce the Oxygen font there?

PS: It doesn't jump around in my local system
Comment 5 Sebastian Kügler 2014-06-06 21:26:15 UTC 
I've not seen it jumping here either.
Comment 6 Andrew Lake 2014-06-06 21:40:58 UTC 
Yeah, let's avoid showing the seconds. I'm fine with using the system typeface as long as the default system font is Oxygen (which it is). No need to break the user typeface preference here.
Comment 7 Martin Klapetek 2014-06-18 13:38:12 UTC 
Was this fixed yet?
Comment 8 David Edmundson 2014-06-18 13:39:44 UTC 
No. Making the the clock not show seconds (comment #6) is your speciality :)
Comment 9 Martin Flöser 2014-06-18 13:42:21 UTC 
> Was this fixed yet?

it's still dancing on my desktop system, but not on my notebook.
Comment 10 Aleix Pol 2014-06-18 14:25:57 UTC 
The bottom line here is that it depends on the used font. Maybe we should just hardcode it?
Comment 11 Martin Flöser 2014-06-18 14:30:53 UTC 
(In reply to comment #10)
> The bottom line here is that it depends on the used font. Maybe we should
> just hardcode it?

yeah, that's what I thought my comment #0 would suggest :-) As this is quite a design part I think enforcing a font would be fine.
Comment 12 Martin Klapetek 2014-06-18 14:39:00 UTC 
It can be improved by aligning to the left instead of right, in which case only the last number would be jumping, not the whole string
Comment 13 David Edmundson 2014-06-18 14:40:45 UTC 
Don't do that, it'd look rubbish.
Comment 14 Martin Klapetek 2014-06-18 14:52:23 UTC 
Git commit 94088588b31abfbb9463006203d05842eab4664f by Martin Klapetek.
Committed on 18/06/2014 at 14:51.
Pushed by mklapetek into branch 'master'.

[lookandfeel] Disable seconds on the lock screen/in InfoPane

M  +1    -1    lookandfeel/contents/components/InfoPane.qml

http://commits.kde.org/plasma-workspace/94088588b31abfbb9463006203d05842eab4664f