Bug 335238 - Half-Pixel Snapping for Mirroring Tool placement
Summary: Half-Pixel Snapping for Mirroring Tool placement
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: git master (please specify the git hash!)
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 427829 433076 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-05-23 10:49 UTC by Paul Geraskin
Modified: 2021-08-09 18:05 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Geraskin 2014-05-23 10:49:21 UTC
Hi devs.

I think we need Pixel Snapping for Mirored Painting. So that painting to be corrected. Mirror should be snapped to pixel or to a half of a pixel. 

Here is a screenshot explanation: http://i.imgur.com/XldOcn8.png

I hope it's understood. Dmitry confirmed this is important.

Thanks.
Comment 1 Halla Rempt 2014-05-24 09:40:23 UTC
Yes, this would be much better. It could be tricky, though -- do we have any tool that does proper pixel snapping?
Comment 2 Paul Geraskin 2014-05-25 10:57:04 UTC
Snapping for other tools is almost ok. The only issue left is this one https://bugs.kde.org/show_bug.cgi?id=335144 . When we start first click - snapping goes no to the  correct pixel. All other stuff for snapping is ok.
Comment 3 Tiar 2020-12-10 22:40:50 UTC
*** Bug 427829 has been marked as a duplicate of this bug. ***
Comment 4 Tiar 2020-12-10 22:42:38 UTC
Please see bug 427829 for more recent explanation.

Also bug 427831 is related.

I don't think "do we have any tool that does proper pixel snapping" is relevant here. The mirroring tool doesn't work with subpixel precision anyway (bug 427831), so there is something wrong there.

The desired effect: snapping every half-pixel, and working properly with all those positions.
Comment 5 Tiar 2021-03-14 00:55:01 UTC
*** Bug 433076 has been marked as a duplicate of this bug. ***
Comment 6 Tiar 2021-08-09 18:05:36 UTC
Git commit 50920d47ae8aca1e74a5641d1e3a3eceb2d53a52 by Agata Cacko.
Committed on 09/08/2021 at 17:47.
Pushed by tymond into branch 'master'.

Implement half-pixel snapping in the mirroring tool

There is no need for more variety here since all tools
have subpixel precision if needed.
Before this commit the mirroring axis could be placed anywhere,
now only positions on exact pixels or in the middle of a pixel
are allowed.
This helps setting the mirroring axis perfectly.

M  +9    -0    libs/ui/canvas/kis_mirror_axis.cpp

https://invent.kde.org/graphics/krita/commit/50920d47ae8aca1e74a5641d1e3a3eceb2d53a52