Bug 335144 - Snapping for selection work a bit incorrectly
Summary: Snapping for selection work a bit incorrectly
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-21 15:06 UTC by Paul Geraskin
Modified: 2014-07-24 15:41 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Geraskin 2014-05-21 15:06:00 UTC
Hi devs!

Snapping for selection work a bit incorrectly. When i start rectangle selection it goes not from the center of the cross. Here is the video: http://youtu.be/52YStv5NOTE

Thanks.
Comment 1 Halla Rempt 2014-06-20 12:46:55 UTC
Well... The cursor moves in screen pixels, the selection in image pixels, so if you start with the cursor a bit outside the center of a pixel, it'll look like this, I guess.
Comment 2 Halla Rempt 2014-06-20 12:47:46 UTC
Might also be a bit of a rounding error, though.
Comment 3 Paul Geraskin 2014-06-20 12:50:17 UTC
In Gimp - rectangle selection snapping works fine. The same in PS. 
I hope it's possible to achive in Krita too. :)
Comment 4 Sven Langkamp 2014-06-22 14:21:27 UTC
There is no rounding error. The behavior was intentionally changed into this behavior. See KisToolRectangleBase::createRect
Comment 5 Sven Langkamp 2014-07-03 23:17:32 UTC
Git commit 2b8cd98cb8020cbe605a2e587c895d51190fb45b by Sven Langkamp.
Committed on 03/07/2014 at 23:16.
Pushed by langkamp into branch 'master'.

round the corner point position of the rectangle base tool, otherwise there is some odd jumping

M  +2    -2    krita/ui/tool/kis_tool_rectangle_base.cpp

http://commits.kde.org/calligra/2b8cd98cb8020cbe605a2e587c895d51190fb45b
Comment 6 Halla Rempt 2014-07-24 15:41:52 UTC
Git commit b7f39267eb4df96db419c58a5d32217b6bf9aa1e by Boudewijn Rempt, on behalf of Sven Langkamp.
Committed on 03/07/2014 at 23:16.
Pushed by rempt into branch 'calligra/2.8'.

round the corner point position of the rectangle base tool, otherwise there is some odd jumping

M  +2    -2    krita/ui/tool/kis_tool_rectangle_base.cpp

http://commits.kde.org/calligra/b7f39267eb4df96db419c58a5d32217b6bf9aa1e