Bug 333180 - About menu item shortcut format wrong
Summary: About menu item shortcut format wrong
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: UI: toplevel window (show other bugs)
Version: 4.6.0
Platform: MacPorts macOS
: NOR minor
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-07 23:15 UTC by Marko Käning
Modified: 2014-10-04 23:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Snapshot showing the "&About KDevelop" menu item (15.99 KB, image/png)
2014-04-07 23:16 UTC, Marko Käning
Details
Snapshot showing the "About" menu item in the program's 1st drop down menu (33.70 KB, image/png)
2014-04-08 06:49 UTC, Marko Käning
Details
Screenshot of the 2 different About boxes (131.59 KB, image/png)
2014-04-13 17:25 UTC, Marko Käning
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Käning 2014-04-07 23:15:28 UTC
In the Help menu one finds a wrongly formatted entry to the About menu item.

Reproducible: Always

Steps to Reproduce:
1. Click into Help menu 
2. Search for About menu item
Actual Results:  
"About KDevelop"

Expected Results:  
"&About KDevelop"
Comment 1 Marko Käning 2014-04-07 23:16:19 UTC
Sorry, I erroneously swapped Actual and Expected results above.
Comment 2 Marko Käning 2014-04-07 23:16:59 UTC
Created attachment 85993 [details]
Snapshot showing the "&About KDevelop" menu item
Comment 3 Kevin Funk 2014-04-08 00:27:37 UTC
Is this the only string with you're seeing with an extra ampersand?
Comment 4 Marko Käning 2014-04-08 06:48:33 UTC
Yes, that's true.

BTW, I also see this behaviour in kate and kwrite, for which I haven't opened a bug report up to now... They however show "A&bout"!

All other KDE applications I have installed do NOT show an about entry in the Help menu. Showing it there actually doesn't make sense on MacOSX, since there is already a dedicated place in the program menu for that. This is obviously done correctly by most KDE applications, except KDevelop, kate and kwrite - as far as I can say.
Comment 5 Marko Käning 2014-04-08 06:49:57 UTC
Created attachment 85998 [details]
Snapshot showing the "About" menu item in the program's 1st drop down menu
Comment 6 Marko Käning 2014-04-11 21:42:31 UTC
(In reply to comment #4)
> BTW, I also see this behaviour in kate and kwrite, for which I haven't
> opened a bug report up to now... They however show "A&bout"!

I've posted a separate bug report for them eventually.
Comment 7 Kevin Funk 2014-04-12 10:41:51 UTC
Thanks. Please cross-link. I'm closing this one, as I don't see how we could fix this.
Comment 8 Marko Käning 2014-04-12 10:48:20 UTC
OK, thanks for letting me  know. I hope that the kate/kwrite devs have a clue what's different for these 3 apps in comparison to so many other KDE applications regarding the About menu item.
Comment 9 Kevin Funk 2014-04-12 11:23:53 UTC
I rather meant to move this to the kdelibs component, but okay. Maybe the Kate guys know more. 
Anyway, we probably need some OSX guy for debugging this.
Comment 10 Marko Käning 2014-04-12 11:25:12 UTC
Oh, okay, sorry that I misunderstood it!

Which component would that be? We could reassign both tickets to the component.
Comment 11 Kevin Funk 2014-04-12 11:43:20 UTC
Nevermind. We handle this in the Kate bug you reported.

*** This bug has been marked as a duplicate of bug 333337 ***
Comment 12 Marko Käning 2014-04-13 17:25:27 UTC
Created attachment 86076 [details]
Screenshot of the 2 different About boxes

Only now I realise that the two menu items actually get created from different parts of the application.

"KDevelop/About" leads to the left About dialog stating it is "KDevelop Platform Version 1.6.0"

"Help/&About KDevelop" leads to the right About dialog stating it is "KDevelop Version 4.6.0"

I just stumbled over it while adding a new KDevelop issue.
Comment 13 Marko Käning 2014-04-13 17:26:20 UTC
I am reopening this because there might be some interference between KDevelop and KDevelop Platform going on here.
Comment 14 RJVB 2014-09-14 10:39:24 UTC
See https://git.reviewboard.kde.org/r/120195/#review66450

That patch doesn't explain why the ampersand ends up being shown, though.
Comment 15 RJVB 2014-10-04 23:20:47 UTC
Git commit ef04be98b35df03f4d8a8117bf38416d19399063 by René J.V. Bertin.
Committed on 04/10/2014 at 23:20.
Pushed by rjvbb into branch 'kde4-legacy'.

OS X: Don't confuse Qt's text-matching heuristic so that it won't put
the "Configure Selection" or "Configure Editor" menu actions under the Mac's Preferences menu item
nor "About KDevelop Platform" under the "About KDevelop" menu item.

REVIEW: 120195
Related: bug 332602

M  +4    -0    plugins/projectmanagerview/projectmanagerviewplugin.cpp
M  +9    -0    shell/mainwindow_p.cpp

http://commits.kde.org/kdevplatform/ef04be98b35df03f4d8a8117bf38416d19399063