Bug 330227 - Image quality sorter leaks memory
Summary: Image quality sorter leaks memory
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Maintenance-Quality (show other bugs)
Version: 4.0.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 01:25 UTC by Michal Sylwester
Modified: 2019-12-24 08:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Sylwester 2014-01-21 01:25:36 UTC
Running maintenance -> image quality sorter leaks memory.
When running on my collection it leaked few MB/sec up to around 7G (around 6-7% of my collection according to progress bar) when I stopped it. Had to exit digikam to release it.

Reproducible: Always

Steps to Reproduce:
1. Run Maintenance -> Image Quality Sorter

Actual Results:  
Memory usage grows around few MB/sec
It is not released until exiting digikam 

Expected Results:  
Memory usage stays flat, any extra memory allocated during quality sorting is released after this process ends.
Comment 1 caulier.gilles 2014-01-21 06:52:55 UTC

*** This bug has been marked as a duplicate of bug 330230 ***
Comment 2 Maik Qualmann 2017-12-17 19:21:28 UTC
Git commit 6a9fd9891a3ff341dc42fe36158cbf0101d513b6 by Maik Qualmann.
Committed on 17/12/2017 at 19:20.
Pushed by mqualmann into branch 'master'.

delete threads from memory when they are finished
Related: bug 375317, bug 375035, bug 321784, bug 325712, bug 328732, bug 331912, bug 344661, bug 345395, bug 350549, bug 381877, bug 338249, bug 329651, bug 329091, bug 387821, bug 381222

M  +2    -1    NEWS
M  +25   -0    libs/database/dbjobs/dbjobsmanager.cpp
M  +35   -0    libs/iojobs/iojobsmanager.cpp

https://commits.kde.org/digikam/6a9fd9891a3ff341dc42fe36158cbf0101d513b6
Comment 3 caulier.gilles 2017-12-17 20:00:45 UTC
Following this commit:

https://commits.kde.org/digikam/6a9fd9891a3ff341dc42fe36158cbf0101d513b6

... the approach to fix this problem is under way and new digiKam 5.8.0 pre-release bundles will be compiled tonight to lets a chance to end-users to give a feedback about this fix before the 5.8.0 official release planed before Christmas 2017.

The bundles will be available in 2 hours at this url:

https://files.kde.org/digikam/

Please do not waste time to test if this file is always valid for next 5.8.0.

Thanks in advance

Gilles Caulier
Comment 4 caulier.gilles 2019-12-24 08:57:01 UTC
Not reproducible with 7.0.0-beta1