Bug 328378 - dolphin did not open URL like trash:/ correctly
Summary: dolphin did not open URL like trash:/ correctly
Status: RESOLVED DUPLICATE of bug 327224
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 4.11.3
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-03 12:22 UTC by Cjacker
Modified: 2013-12-03 14:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cjacker 2013-12-03 12:22:21 UTC
Dolphine can not process some Directory-Like url properly.

Run from commandline:
dolphin trash:/
It will always fallback to home Dir.

The "Desktop Icons" like trash icon will be effected.

A fix like this:

@@ -1239,6 +1239,12 @@

     if (item.isMimeTypeKnown()) {
         const QString& mimetype = item.mimetype();
+        //for example, "trash:/" will be a "inode/directory".
+        //but KFileItem::isDir() failed, it call 'S_ISDIR' only.
+        //handle it here.
+        if(mimetype == QLatin1String("inode/directory")) {
+            return url;
+        }

         if (browseThroughArchives && item.isFile() && url.isLocalFile()) {
             // Generic mechanism for redirecting to tar:/<path>/ when clicking on a tar file,                                                                            


Reproducible: Always
Comment 1 Emmanuel Pescosta 2013-12-03 13:34:11 UTC
Thanks for the bug report!

Hmm I can't reproduce this bug with trash:/ in Dolphin 4.11.97, but there are other ways to trigger this home-dir redirection problem.

About the url handling on Dolphin startup in general:
There are several problems with some urls, with item selection "--select" and so on (e.g zip files).
I'll have a look at this code and bring up a patch to fix these problems. The nice
positive side-effect is, that it should be possible to reuse this code for the "open path"
actions (open an new Dolphin instance and scroll to the right item, open a new tab and 
scroll to the right item).
I already have some ideas in my mind ;)
Comment 2 Frank Reininghaus 2013-12-03 14:20:05 UTC
This is a regression in 4.11.3 (caused by an attempt to work around bug 318683) that has been fixed already.

However, the fix was to revert the workaround for bug 318683. Maybe your idea could be used instead of the original patch to work around this bug without regressions? It would be great if you could rebase your patch on Dolphin >= 4.11.4 and submit it to https://git.reviewboard.kde.org/. Thanks for your help!

*** This bug has been marked as a duplicate of bug 327224 ***