Bug 324362 - Removing Samba share doesn't update overlay
Summary: Removing Samba share doesn't update overlay
Status: RESOLVED DUPLICATE of bug 393122
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: general (show other bugs)
Version: 4.11.0
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-01 16:43 UTC by Kai Uwe Broulik
Modified: 2018-04-26 08:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2013-09-01 16:43:31 UTC 
When a file or directory is shared via Samba it gets an overlay icon denoting this. However, when I remove the share, the icon is not removed until I refresh the view.

Reproducible: Always

Steps to Reproduce:
1. Have a folder shared via Samba
2. Remove Samba share
3.
Actual Results:  
Overlay is still visible

Expected Results:  
Overlay is gone
Comment 1 Frank Reininghaus 2013-09-02 21:00:17 UTC 
Thanks for the bug report. I have no access to any Samba shares, so I cannot really test or debug this. Some questions:

(a) Where do you see the icons with the overlays? Do you visit remote:, smb:, or something like that?

(b) Do you happen to know how these overlays are implemented? I would assume that they are provided by KFileItem::overlays()?

To fix this, Dolphin must obviously receive some notification that the share is removed. We already do listen to KDirLister's refreshItems signal, so if KIO would emit this signal when a share is removed, everything should be fine.
Comment 2 Frank Reininghaus 2013-09-14 13:18:28 UTC 
If you can provide at least a bit of additional information, please reopen and re-assign to kio or kio/smb if appropriate. I still cannot imagine that anything can be done about this inside Dolphin, but if you think that I'm wrong, I really need more information. Thanks.
Comment 3 Julian Steinmann 2018-03-31 10:40:26 UTC 
What should we do with this report? I cannot triage this bug on my own (no Samba share available), and either this is still an "issue" or it has since been fixed. If it is still an issue we should probably file a bug against KIO to provide us with a signal related to Samba shares.
Comment 4 Julian Steinmann 2018-04-15 16:11:23 UTC 
Please update this report if you are able to test this bug with newer versions of Dolphin. Thanks!
Comment 5 Patrick Silva 2018-04-20 15:54:13 UTC 
Confirmed on neon dev unstable.
Bug 393122 seems related/duplicated.
Comment 6 Julian Steinmann 2018-04-26 08:59:14 UTC 
This does indeed look like a duplicate of 393122. I'll close this bug, as the other one is correctly assigned to KIO.

*** This bug has been marked as a duplicate of bug 393122 ***