Bug 323747 - KRecentDocument::add() is broken after commit 48b78ce3
Summary: KRecentDocument::add() is broken after commit 48b78ce3
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Git
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
: 322529 323702 324110 329084 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-19 21:09 UTC by Eugene Shalygin
Modified: 2014-01-27 01:14 UTC (History)
4 users (show)

See Also:
Latest Commit: http://commits.kde.org/kdelibs/13f0e65f8b0bbee8fa32d7634743026a518903c1
Version Fixed In: 4.11.1

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Shalygin 2013-08-19 21:09:11 UTC 
in line 113 of krecentdocument.cpp:
QString ddesktop = dStr + QLatin1String(".desktop")
results of recentDocumentDirectory() call is forgotten, therefore the function creates .desktop files in the current dir. The line should look like:
QString ddesktop = path + dStr + QLatin1String(".desktop")

Reproducible: Always
Comment 1 Eugene Shalygin 2013-08-19 21:10:07 UTC 
line 115, sorry. But it is easy to find anyway
Comment 2 Michael Pyne 2013-08-20 00:35:21 UTC 
Git commit 13f0e65f8b0bbee8fa32d7634743026a518903c1 by Michael Pyne.
Committed on 20/08/2013 at 00:27.
Pushed by mpyne into branch 'KDE/4.11'.

krecentdocument: Ensure full path is saved with entries.

This was accidentally broken in commit 48b78ce3e, which resulted in only
the filename (not the full path) being saved with KRecentDocument
entries.

The suggested fix in the reported bug is not adequate as 'dStr' can be
used later in the function, so it needs to retain the semantics it had
prior to commit 48b78ce3e. We do appreciate the prompt report though!.
FIXED-IN:4.11.1

M  +1    -1    kio/kfile/krecentdocument.cpp

http://commits.kde.org/kdelibs/13f0e65f8b0bbee8fa32d7634743026a518903c1
Comment 3 Jekyll Wu 2013-08-21 13:10:24 UTC 
*** Bug 323702 has been marked as a duplicate of this bug. ***
Comment 4 Jekyll Wu 2013-08-21 13:12:24 UTC 
*** Bug 322529 has been marked as a duplicate of this bug. ***
Comment 5 Jekyll Wu 2013-08-27 11:35:26 UTC 
*** Bug 324110 has been marked as a duplicate of this bug. ***
Comment 6 Wolfgang Bauer 2013-08-27 15:09:56 UTC 
(In reply to comment #2)
> Git commit 13f0e65f8b0bbee8fa32d7634743026a518903c1 by Michael Pyne.
> Committed on 20/08/2013 at 00:27.
> Pushed by mpyne into branch 'KDE/4.11'.
This commit fixes Bug#324110 for me.
Thank you!
Comment 7 Christoph Feck 2014-01-27 01:14:04 UTC 
*** Bug 329084 has been marked as a duplicate of this bug. ***