Bug 323507 - digitaglinktree : usage with mysql instead of sqlite [patch]
Summary: digitaglinktree : usage with mysql instead of sqlite [patch]
Status: RESOLVED NOT A BUG
Alias: None
Product: digikam
Classification: Applications
Component: Database-Mysql (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-14 19:47 UTC by Harald.Heigl1000+kde
Modified: 2017-07-25 10:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.0.0


Attachments
digitaglinktree for use with sqlite and mysql (36.15 KB, application/octet-stream)
2013-10-19 20:49 UTC, Harald.Heigl1000+kde
Details
Patch to current digitaglinktree (11.65 KB, patch)
2013-10-27 21:52 UTC, Harald.Heigl1000+kde
Details
Patch to the inoffical 1.8.2 digitaglinktree (14.30 KB, patch)
2013-10-27 21:53 UTC, Harald.Heigl1000+kde
Details
digitaglinktree 1.8.4beta (37.41 KB, application/octet-stream)
2013-12-03 10:26 UTC, krienke
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald.Heigl1000+kde 2013-08-14 19:47:45 UTC
2 questions:
In this bug list I have found 2 bugs/wishes containing versions for digitaglinktree (1.8.1 and 1.8.2), but I only find a relatively old version in the git-repo. Is there another official repo for digitaglinktree?
- https://bugs.kde.org/show_bug.cgi?id=293297
- https://bugs.kde.org/show_bug.cgi?id=293832

The second question is more or less a feature request: I'm using mysql for convencience (accessing from more than one computer), I'd like to run digitaglinktree on my NAS with mysql-db. Has anyone adapted or thought about adapting this script to mysql?

Thanks,
Harald

Reproducible: Always
Comment 1 Harald.Heigl1000+kde 2013-10-19 20:49:09 UTC
Created attachment 82956 [details]
digitaglinktree for use with sqlite and mysql

Had some time to edit the script ...
The only disadvantage is: it doesn't use the lightweigth sqlite3 anymore, but the DBI-Perl-System for bot database-types.

It now works with SQLite AND Mysql-Databses (added some options therfore like type, user and password).
Comment 2 caulier.gilles 2013-10-19 20:59:23 UTC
Please, provide a patch against current implementation from git/master instead a full script file. Thanks in advance

Gilles Caulier
Comment 3 Harald.Heigl1000+kde 2013-10-19 22:01:54 UTC
Thanks for your comment, I just wanted to change the script and not download the whole git-repository. But for now I did it, the only thing is ...

Here in this bugsystem there seem to be some newer changes (1.8-1.8.2 - also see the links in my first comment), master only contains a relatively old version 1.7.0 (from 2008).

Should I patch the 1.7.0 (I could do this, I just changed some lines here and there ...), or is there another branch with the newer version?

regards,
Harald
Comment 4 caulier.gilles 2013-10-20 05:18:21 UTC
I'm not sure if script has not changed since 1.7.0. We are now in 4.0.0 beta stage...

As i don't manage this script code, i'mnot sure about the story.

You don't need to checkout whole repository to make a patch with current implementation.
Just use web git interface to take last scrit version :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/show/utilities/scripts/digitaglinktree

Gilles Caulier
Comment 5 Harald.Heigl1000+kde 2013-10-27 21:52:08 UTC
Created attachment 83165 [details]
Patch to current digitaglinktree

Sorry, in master is only the 5 year old digitaglinktree, this patch is based on this 1.7.0 version out of master.

But in this buglog there are also some good changes to this script, so I've also a patch to the "inofficial" 1.8.2, I'll upload here too.

If there are any problems let me know.
Comment 6 Harald.Heigl1000+kde 2013-10-27 21:53:57 UTC
Created attachment 83166 [details]
Patch to the inoffical 1.8.2 digitaglinktree
Comment 7 caulier.gilles 2013-10-28 06:57:01 UTC
Why you don't take current implementation of script from git/master and patch it ?

I cannot accept a patch against a older version as 1.x.

Script have changes since 1.x. Your patch must take a care about and must be tested with current implementation with database schema...

Gilles Caulier
Comment 8 caulier.gilles 2013-10-28 07:01:01 UTC
Your patches are against an older digiKam release based on 1.x version ?

We are currently on digiKam 3.5.0 release and 4.0.0 is on the way...

We cannot accept any patches like this. Please _make_ and _test_ a patch against 3.5.0 release which is the last stable, to be sure to include all last database schema changes.

Gilles Caulier
Comment 9 Harald.Heigl1000+kde 2013-10-29 20:20:32 UTC
Sorry I took the file in the link you gave me for the patch: https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/show/utilities/scripts/digitaglinktree

So it is definitely git-master (if the link is correct), I just said the digtaglinktree-version is at 1.7.0 and 5 years old (it's written in the digitaglinktree file), never said that digiKam is at version 1.x.

But honestly it's only tested against digiKam 3.1.0 (my current-digikam version), not against 3.5.0, I don't know database schema changes since then, perhaps if I find some time ...
Comment 10 caulier.gilles 2013-10-30 07:34:45 UTC
3.1.0 is safe to test. There is no DB changes since 3.1.0 to 3.5.0.

DB schema is given in a LibreOffice sheet in core/project/documents folder

Gilles Caulier
Comment 11 caulier.gilles 2013-11-30 09:08:23 UTC
krienke,

Another entry about digikamlinktree for you...

Gilles Caulier
Comment 12 krienke 2013-12-03 10:25:35 UTC
@Harald.Heigl1000+kde@gmail.com 

I tried to merge my 1.8.3 version with your 1.8.3 version into a new attached 1.8.4beta version that incorporates your nice code for MYSQL support. 

For me 1.8.4beta seems to work, however I would ask you to check MYSQL support since I still use sqlite. You are probably using MYSQL and so you should have better test data than I have.

Thanks
Rainer
Comment 13 krienke 2013-12-03 10:26:43 UTC
Created attachment 83893 [details]
digitaglinktree 1.8.4beta

digitaglinktree test version 1.8.4beta
Comment 14 caulier.gilles 2014-08-24 08:27:18 UTC
*** Bug 325273 has been marked as a duplicate of this bug. ***
Comment 15 caulier.gilles 2015-12-02 21:46:52 UTC
as Databse schema are currently under re-writting for Mysql and fully uncompatible with patch provided in bug 323507, we must close this report as invalid