Bug 320515 - [kde-windows] Kanagram lacks icon in the start menu
Summary: [kde-windows] Kanagram lacks icon in the start menu
Status: RESOLVED FIXED
Alias: None
Product: kanagram
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks: 320424
  Show dependency treegraph
 
Reported: 2013-05-31 06:54 UTC by Jekyll Wu
Modified: 2013-05-31 10:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.10.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jekyll Wu 2013-05-31 06:54:43 UTC
See bug 320424 and bug 320514

I notice that the build system actually already contains the call of kde4_add_app_icon :

kde4_add_app_icon(kanagramdesktop_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/../icons/hi*-app*-kanagram.png")


But I think there is a relative path mistake there. Since that line appears in src/desktop/CMakeLists.txt,  it should be written as :

kde4_add_app_icon(kanagramdesktop_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/../../icons/hi*-app*-kanagram.png")
Comment 1 Anne-Marie Mahfouf 2013-05-31 07:42:41 UTC
Git commit 80c550810ffd79405fe92cf71210c39bc863b73f by Anne-Marie Mahfouf.
Committed on 31/05/2013 at 09:41.
Pushed by annma into branch 'master'.

Fix pattern path to install icons correctly on Windows
FIXED-IN: 4.10.3

M  +1    -1    src/desktop/CMakeLists.txt

http://commits.kde.org/kanagram/80c550810ffd79405fe92cf71210c39bc863b73f
Comment 2 Anne-Marie Mahfouf 2013-05-31 07:43:44 UTC
Git commit c74a85f8b5bf06a83d8bcea7e8958536c791cca1 by Anne-Marie Mahfouf.
Committed on 31/05/2013 at 09:42.
Pushed by annma into branch 'KDE/4.10'.

Fix pattern path to install icons correctly on Windows - backport

M  +1    -1    src/desktop/CMakeLists.txt

http://commits.kde.org/kanagram/c74a85f8b5bf06a83d8bcea7e8958536c791cca1
Comment 3 Patrick Spendrin 2013-05-31 10:14:27 UTC
Git commit e4cf19ef5e159ba2bdf9fa815130ec988a13ed07 by Patrick Spendrin.
Committed on 31/05/2013 at 10:26.
Pushed by sengels into branch 'kde-4.10'.

add app icon for kanagram

A  +27   -0    portage/kde/kdeedu/kanagram/0001-Fix-pattern-path-to-install-icons-correctly-on-Windo.patch
M  +2    -0    portage/kde/kdeedu/kanagram/kanagram-20110621.py

http://commits.kde.org/emerge/e4cf19ef5e159ba2bdf9fa815130ec988a13ed07