Bug 320514 - [kde-windows] khangman lacks icon in the start menu
Summary: [kde-windows] khangman lacks icon in the start menu
Status: RESOLVED FIXED
Alias: None
Product: khangman
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Anne-Marie Mahfouf
URL:
Keywords:
Depends on:
Blocks: 320424
  Show dependency treegraph
 
Reported: 2013-05-31 06:51 UTC by Jekyll Wu
Modified: 2013-05-31 10:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.10.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jekyll Wu 2013-05-31 06:51:26 UTC
See bug 320424

I notice that the build system actually already contains the call of kde4_add_app_icon :

    kde4_add_app_icon(khangman_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/../icons/hi*-app-khangman.png")

But I think there is a relative path mistake there. Since that line appears in src/desktop/CMakeLists.txt,  it should be written as :

    kde4_add_app_icon(khangman_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/../../icons/hi*-app-khangman.png").
Comment 1 Anne-Marie Mahfouf 2013-05-31 07:31:45 UTC
Git commit 27756bdf4885a1a7323b1a198d73743c34032ef2 by Anne-Marie Mahfouf.
Committed on 31/05/2013 at 09:21.
Pushed by annma into branch 'master'.

Fix pattern path to install icons correctly on Windows
FIXED-IN: 4.10.3

M  +1    -1    src/desktop/CMakeLists.txt

http://commits.kde.org/khangman/27756bdf4885a1a7323b1a198d73743c34032ef2
Comment 2 Anne-Marie Mahfouf 2013-05-31 07:35:17 UTC
Git commit cf5a923b4223c505cc962a1ab2187a981697c6ee by Anne-Marie Mahfouf.
Committed on 31/05/2013 at 09:34.
Pushed by annma into branch 'KDE/4.10'.

Fix pattern path to install icons correctly on Windows - backport

M  +1    -1    src/desktop/CMakeLists.txt

http://commits.kde.org/khangman/cf5a923b4223c505cc962a1ab2187a981697c6ee
Comment 3 Patrick Spendrin 2013-05-31 10:14:21 UTC
Git commit fc0fe3b429ebfe6c39566430ef24afd54134821c by Patrick Spendrin.
Committed on 31/05/2013 at 10:22.
Pushed by sengels into branch 'kde-4.10'.

add app icon for khangman

A  +27   -0    portage/kde/kdeedu/khangman/0001-Fix-pattern-path-to-install-icons-correctly-on-Windo.patch
M  +2    -0    portage/kde/kdeedu/khangman/khangman-20110621.py

http://commits.kde.org/emerge/fc0fe3b429ebfe6c39566430ef24afd54134821c