Bug 317436 - kruler should be able to stay above all other windows
Summary: kruler should be able to stay above all other windows
Status: RESOLVED FIXED
Alias: None
Product: kruler
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Alexander Neundorf
URL:
Keywords:
: 208947 303366 332106 377502 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-03-27 12:26 UTC by Martin Koller
Modified: 2017-06-26 16:52 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Patch for always on top (2.95 KB, patch)
2013-04-15 22:37 UTC, Manuel Galiu
Details
Patch for always on top v2 (3.99 KB, patch)
2013-04-16 23:27 UTC, Manuel Galiu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Koller 2013-03-27 12:26:48 UTC
kruler shows no window manager menu and it has no option to configure it to stay above all other windows.
Please add the possibility to have it stay on top all other windows

Reproducible: Always
Comment 1 Christoph Feck 2013-03-29 13:07:34 UTC
The workaround is to press Alt+F3 to get the window menu.
Comment 2 Manuel Galiu 2013-04-15 22:37:51 UTC
Created attachment 78945 [details]
Patch for always on top

Hi,
I've seen a junior issue assigned for this so I've tried to make it.

I've made in the context menu a new sub-menu called layer where I added 2 options - Always on top layer and Normal layer. When one is selected the other one is set to disable. 

Also I've set the default behavior Always on top.

Hope it's good,
Manuel
Comment 3 Martin Koller 2013-04-16 06:03:49 UTC
Comment on attachment 78945 [details]
Patch for always on top

I suggest that you do it with just one checkable action "Keep Above Others" as it is done in the kwin menu. For a boolean flag, there is no need to have a submenu and two actions.

To the patch - this part is wrong:
QLatin1String( "length_short" ) 
and
 Qt::Key_N, QLatin1String( "length_medium" ) 
It seems a copy/paste error from another action.
Comment 4 Manuel Galiu 2013-04-16 23:27:47 UTC
Created attachment 78972 [details]
Patch for always on top v2

Hi,
I've took in consideration your comment and I've made a new patch. I've made only one check able  actionset in the main context menu. Also I've added the functionality to save the user choice

Thank you for your help..
Comment 5 Martin Koller 2013-04-17 07:16:18 UTC
Comment on attachment 78972 [details]
Patch for always on top v2

+  KMenu *mLayerMenu;
This seems no longer needed.
But as I'm not the maintainer, please create a review request at reviewboard.kde.org
Thanks for your work!
Comment 6 Christoph Feck 2013-07-11 22:48:25 UTC
*** Bug 303366 has been marked as a duplicate of this bug. ***
Comment 7 Christoph Feck 2014-03-13 21:00:13 UTC
*** Bug 332106 has been marked as a duplicate of this bug. ***
Comment 8 Raymond L Kornele 2014-03-14 03:08:18 UTC
I also discovered that while in the advanced selection of the Alt-F3 menu
you can turn on the borders.


KrazyKyngeKorny (Krazy, not stupid)



On Thu, Mar 13, 2014 at 2:00 PM, Christoph Feck <christoph@maxiom.de> wrote:

> https://bugs.kde.org/show_bug.cgi?id=317436
>
> Christoph Feck <christoph@maxiom.de> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |KrazyKyngeKorny@gmail.com
>
> --- Comment #7 from Christoph Feck <christoph@maxiom.de> ---
> *** Bug 332106 has been marked as a duplicate of this bug. ***
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>
Comment 9 Martin Koller 2014-03-14 06:25:08 UTC
to comment #8: I can not reproduce this with 4.13beta2 (but in fact it is not directly related to this issue)
Comment 10 Alexander Neundorf 2016-04-27 20:38:01 UTC
*** Bug 208947 has been marked as a duplicate of this bug. ***
Comment 11 Alexander Neundorf 2016-04-27 20:40:26 UTC
Actually in KDE 3 kruler was always on top.

What I'm doing now is adding a special kwin rule for kruler :-/
Comment 12 Alexander Neundorf 2016-04-27 20:42:08 UTC
Looking at the commit logs it looks like kruler is more or less unmaintained.
Comment 13 Alexander Neundorf 2016-05-29 21:58:01 UTC
I committed a modified version of the attached patch, it is now a setting in the settings dialog, see http://commits.kde.org/kruler/ab152c2f7ee07cd3eb8f10b902ebeff1b4b6e182 .
Comment 14 Martin Koller 2016-05-30 06:23:30 UTC
Thanks a lot! Very appreciated!
Comment 15 Christoph Feck 2017-03-12 02:37:38 UTC
*** Bug 377502 has been marked as a duplicate of this bug. ***