Created attachment 76309 [details]
Screenshot showing the broken rendering of a timeline:/today view.
Nepomuk just got a fix for bug#311577 which makes the timeline:/ KIO return real filesystem URLs instead of Nepomuk URLs.
This breaks Dolphin's "Details View Mode" as it tries to render the result list of "timeline:/today" and "timeline:/yesterday" as a tree, resulting in weirdly indented files (see screenshot in attachment).
Dolphin should treat the "today" and "yesterday" timeline in the same way as "nepomuksearch" results - dismissing any tree view related things and just resort to displaying a regular file list.
The tree view in combination with timeline:/ URLs seems to be a little buggy in general.
When I am in "compact" or "icon" view mode and change to "details" while having such an URL open, the files show up in the broken tree view with a certain order. When I reload the viewport, though (e.g. with F5), the files are shown in a different order.
See the screen shot I attached.
Created attachment 77498 [details]
Dolphin details view file order
Hello Elias and Janek, I think this patch https://git.reviewboard.kde.org/r/109045/ will solve all two problems ;)
Can you please test it? Thanks
(In reply to comment #3)
> Hello Elias and Janek, I think this patch
> https://git.reviewboard.kde.org/r/109045/ will solve all two problems ;)
> @Elias, @Janek:
> Can you please test it? Thanks
Is this patch meant to apply against 4.10.0 or only master/4.11? Can't apply it against 4.10.0.
(In reply to comment #4)
> (In reply to comment #3)
> > Hello Elias and Janek, I think this patch
> > https://git.reviewboard.kde.org/r/109045/ will solve all two problems ;)
> > @Elias, @Janek:
> > Can you please test it? Thanks
> Is this patch meant to apply against 4.10.0 or only master/4.11? Can't apply
> it against 4.10.0.
Currently I'm on 4.10, not on master, so I can't test it here. Sorry.
I'd need to download a Neon image first. Maybe I can do this tonight.
(In reply to comment #6)
> Currently I'm on 4.10, not on master, so I can't test it here. Sorry.
> I'd need to download a Neon image first. Maybe I can do this tonight.
How is that going to help? I thought that Neon only provides binary packages. In any case, considering that the patch does not even apply correctly to master, I'd wait a bit before putting too much effort into testing this.
I does, but I still can compile custom packages there. ;-)
Git commit 8008bc233d8447794df6f4cdc8c3f0ee7e8ac628 by Emmanuel Pescosta.
Committed on 27/02/2013 at 13:35.
Pushed by emmanuelp into branch 'master'.
Big Thanks to Frank Reininghaus, who helped me a lot with these
* Fixed the "Network browser" and "timeline" issues, by using the
KDirLister's itemsAdded(KUrl,KFileItemList) signal -> Use the
given Url to define the parent-child relationship.
* Changed the name of the slot "slotNewItems" to "slotItemsAdded"
for consistency with the signal.
* Use a QHash<KFileItem, ItemData*> instead of a QSet<KFileItem> to
store the filtered data (needed to keep the O(1) lookup for filtered
KFileItems in slotItemsDeleted + needed to fix bug 311912 "After
erasing a filter, some thumbnails randomly disappear")
* Made the determination of the "expandedParentsCount" slightly
simpler - just adding 1 to the parent's level (Also needed to fix the
"Network browser" and "timeline" issues)
Related: bug 304565, bug 311912, bug 315593
M +69 -64 dolphin/src/kitemviews/kfileitemmodel.cpp
M +13 -8 dolphin/src/kitemviews/kfileitemmodel.h
M +9 -3 dolphin/src/tests/kfileitemmodelbenchmark.cpp
M +1 -1 dolphin/src/tests/kfileitemmodeltest.cpp
*** Bug 319374 has been marked as a duplicate of this bug. ***