Bug 311372 - Impossible to add telepathy-sunshine in account in KCM
Summary: Impossible to add telepathy-sunshine in account in KCM
Status: RESOLVED UPSTREAM
Alias: None
Product: telepathy
Classification: Unmaintained
Component: accounts-kcm (show other bugs)
Version: 0.5.1
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-08 21:39 UTC by K G
Modified: 2013-04-11 12:02 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Console log (625 bytes, text/plain)
2012-12-08 21:41 UTC, K G
Details
Screenshot (58.02 KB, image/png)
2012-12-08 21:43 UTC, K G
Details
Log from dbus-monitor (1.96 KB, text/plain)
2012-12-14 23:06 UTC, K G
Details

Note You need to log in before you can comment on or make changes to this bug.
Description K G 2012-12-08 21:39:42 UTC
When I put all data message Failed to create Account appears. 





Reproducible: Always

Steps to Reproduce:
1.Choose Add Account in KCM
2. Select Gadu-Gadu (telepathy sunshine)
3. Generic Settings window Appears
4. Put All data.
Actual Results:  
Error with creating Account.

Expected Results:  
New account created.
Dialog for telepathy sunshine in stand of generic one.

telepathy-sunshine 0.2.0-2.gite26dd019.fc16

Adding account by Empathy or mc-tool works.


It seams that there is something wrong with password parameter.
Comment 1 K G 2012-12-08 21:41:35 UTC
Created attachment 75731 [details]
Console log

Seams that password is not passed correctly
Comment 2 K G 2012-12-08 21:43:34 UTC
Created attachment 75732 [details]
Screenshot

There is strange order of parameters. I don't know if it's related with problem somehow.
Comment 3 Martin Klapetek 2012-12-09 07:00:14 UTC
Thanks for the report, unfortunately GaduGadu support in Telepathy is not really good, there is a bug 291354, which renders GG useless with Telepathy :/ 

The interface you're seeing is an autogenerated one, sort of a fallback widget. This is loaded when the Accounts KCM is unable to find the proper library, can you check you have "ktpaccountskcm_plugin_sunshine.so" present?
Comment 4 K G 2012-12-09 17:28:14 UTC
I think bug 291354 is related with telepathy-haze not telepathy-sunshine. th has no support for importing contacts but there is no problem with adding account. 

With ts after adding ts account by mc-tool contacts are imported correctly. However, in that case i have to remove account and readd it  after every restart: KTP remembers account, but MC not, probably because of lack gnomekeyring, and no KWallet support in mc-tool. 

No I haven't got  ktpaccountskcm_plugin_sunshine.so its not provided by fedora's rpm. 

However, it should work with fallback gui, should'n it?
How can I debug dbus massage send during creating account?
Comment 5 David Edmundson 2012-12-09 18:59:12 UTC
Telepathy has two ways of doing passwords

The old way was that mission control would store them internally in gnome-keyring
The new way is that the applications store the password (so we can put them in kwallet)

The connection managers needed to be updated for the new method. Telepathy-Sunshine was never updated, so telepathy never actually asks us for the password.

If you have gnome-keyring it /should/ work... but I don't know. To us it's deprecated.
Comment 6 David Edmundson 2012-12-09 19:00:42 UTC
Edit:
Actually it won't work. We always intercept the password to put it in kwallet instead of sending it to MC, because otherwise it causes problems for the other CMs.
Comment 7 K G 2012-12-12 22:16:54 UTC
But I don't wont to use gnomeKeyring.  I wont to can add account by KTP and store password in KWallet. But this is not the clue of problem.

Can you reproduce problem with creating account? I not can you tell me how to debug parameters of new account sent to mc?
Comment 8 K G 2012-12-14 23:06:30 UTC
Created attachment 75841 [details]
Log from dbus-monitor

As you can see possword is not send during creating account. There is only account name and nothing else (there should be couple of other parameters thought)
Comment 9 K G 2012-12-16 19:09:49 UTC
I've added so and desktop file for sunshine plugin and I have proper dialog but I've got the same problem. 

Still only account name is sent as a parameter during creating account (like in attached dbus-monitor log)
Comment 10 David Edmundson 2012-12-16 19:30:16 UTC
Which is what I said in comment number 6.

We deliberately remove it because it breaks every other CM that uses the new password spec, and annoyingly there's no way at runtime to tell the two apart.

Line 235 of add-account-assistant.cpp
Comment 11 Martin Klapetek 2013-04-11 12:02:28 UTC
So unless telepathy-sunshine is updated to use the new password spec, we won't allow it. Sorry.