Bug 306354 - [PATCH] Cannot play tracks from Rhythmbox DAAP collection due to 403 error
Summary: [PATCH] Cannot play tracks from Rhythmbox DAAP collection due to 403 error
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: Collections/DAAP (other bugs)
Version First Reported In: 2.6-git
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 2.8
Assignee: Amarok Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 15:22 UTC by Daniel Stöckel
Modified: 2023-01-02 05:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Fix for the described behavior (3.40 KB, patch)
2012-09-06 15:24 UTC, Daniel Stöckel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Stöckel 2012-09-06 15:22:49 UTC
The server used by Rhythmbox requires the session id to be appended to the trac URL. Otherwise it returns a HTTP 403 error. Simply appending the session id fixes the problem.

This is a followup from https://bugs.kde.org/show_bug.cgi?id=306351

Reproducible: Always

Steps to Reproduce:
1. Compile Amarok with my patch from https://bugs.kde.org/show_bug.cgi?id=306351
2. Publish your collection from Rhythmbox.
3. Play a song from the DAAP collection.
Actual Results:  
The song does not play due to "Permission denied" error from the server.

Expected Results:  
The song plays.

Adding the session id to the track URL fixes the problem. I will attach a patch that does exactly this. Testing with mt-daap revealed no regression. This bug might also be the reason for the behavior seen in: https://bugs.kde.org/show_bug.cgi?id=275640#c8

Problem: As tracks remain in the Amarok playlist, they will now have an invalid session-id attribute. To solve this either all tracks stemming from DAAP collections need to be removed or the session-id attribute has to be rewritten. (Again mt-daap does not seem to care)
Comment 1 Daniel Stöckel 2012-09-06 15:24:22 UTC
Created attachment 73708 [details]
Fix for the described behavior

This simply adds an additional int sessionId parameter to the DaapTrac class.
This is then appended to the track URL.
Comment 2 Myriam Schweingruber 2012-09-07 02:15:03 UTC
Thanks again, please also submit this to http://reviewboard.kde.org
Comment 3 Daniel Stöckel 2012-09-07 09:52:20 UTC
I submitted my patch to reviewboard: https://git.reviewboard.kde.org/r/106370/
Comment 4 Andrew Crouthamel 2018-11-10 03:11:06 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Andrew Crouthamel 2018-11-12 03:23:04 UTC
Changing back to REPORTED per request of Myriam (Amarok dev).
Comment 6 Justin Zobel 2022-12-03 09:01:27 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 7 Bug Janitor Service 2022-12-18 05:14:24 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Bug Janitor Service 2023-01-02 05:28:21 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!