Bug 306351 - [PATCH] Loading DAAP collections from Rhythmbox does not work
Summary: [PATCH] Loading DAAP collections from Rhythmbox does not work
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: Collections/DAAP (show other bugs)
Version: 2.6-git
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 2.8
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 15:10 UTC by Daniel Stöckel
Modified: 2023-01-02 05:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
A patch fixing this bug (1.74 KB, patch)
2012-09-06 15:12 UTC, Daniel Stöckel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Stöckel 2012-09-06 15:10:14 UTC
The server used in Rhythmbox requires that the revision-number field is passed in a daap /update request. As this is currently not the case the collection does not show up in Amarok >= 2.6.0 (and probably lower versions).

See https://mail.gnome.org/archives/commits-list/2012-March/msg07220.html

This might be a potential duplicate of https://bugs.kde.org/show_bug.cgi?id=275640

Reproducible: Always

Steps to Reproduce:
1. Publish your collection in Rhythmbox
2. Open Amarok
3. Wait for the collection to never appear
Actual Results:  
No collection showing up.

Expected Results:  
A collection showing up.

This can be easily fixed by appending &revision-number=1 to the login string. I have created a patch that does exactly this.
Comment 1 Daniel Stöckel 2012-09-06 15:12:09 UTC
Created attachment 73707 [details]
A patch fixing this bug

A more clean implementation might be to wait a certain amount of time and then add the revision-number. I have tested with mt-daap which does not seem to mind the additional field.
Comment 2 Myriam Schweingruber 2012-09-07 02:12:31 UTC
Thank you for the patch. Could you please submit it to http://reviewboard.kde.org ? You will need to get an identity on http://identity.kde.org first.
Comment 3 Daniel Stöckel 2012-09-07 09:52:53 UTC
I submitted my patch to review board: https://git.reviewboard.kde.org/r/106366/
Comment 4 Andrew Crouthamel 2018-11-10 03:17:27 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Andrew Crouthamel 2018-11-12 03:23:01 UTC
Changing back to REPORTED per request of Myriam (Amarok dev).
Comment 6 Justin Zobel 2022-12-03 09:01:36 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 7 Bug Janitor Service 2022-12-18 05:14:23 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Bug Janitor Service 2023-01-02 05:28:20 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!