Bug 302562 - Rename "View Image" to "Preview".
Summary: Rename "View Image" to "Preview".
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Preview-Engine (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-26 14:08 UTC by Dotan Cohen
Modified: 2017-08-04 21:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.7.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2012-06-26 14:08:30 UTC
View -> View Image should probably be renamed to View -> Preview as that seems to be the proper name for the feature according to the confusion on bug #302559.
Comment 1 Smit Mehta 2012-06-26 14:31:08 UTC
Hi Dotan, Gilles

What do you think? If its fine with you, I can find the required code and patch it.

Smit
Comment 2 caulier.gilles 2012-06-26 15:10:45 UTC
Agree. View->View Image menu entry is typo redondant. View->Preview Image is fine.

No need a patch here in Bugzilla. Please patch directly git/master (not 3.0.0 branch). Commit will be backported to 3.0.0 later...

Don't forget to patch NEWS file too...

Gilles Caulier
Comment 3 Smit Mehta 2012-06-26 17:47:47 UTC
Git commit 82dfdf1c0ed12fe0560de4743ea3ecc5722257c8 by Smit Mehta.
Committed on 26/06/2012 at 19:42.
Pushed by smitmehta into branch 'master'.

Fixing typo. View Image -> Preview Image

M  +1    -1    NEWS
M  +1    -1    digikam/main/digikamapp.cpp

http://commits.kde.org/digikam/82dfdf1c0ed12fe0560de4743ea3ecc5722257c8
Comment 4 caulier.gilles 2012-06-26 21:48:01 UTC
Smit,

You miss to patch icon-view Context Menu where there is a "View" action which is used to switch in preview mode...

Gilles Caulier
Comment 5 Smit Mehta 2012-06-27 05:44:35 UTC
Gilles,

I changed the line 843 of digikam/main/digikamapp.cpp. I think that only governs the name of that action. However even I am surprised that it didnt change anything. When I used grep on the digiKam directory, i didnt see any other code affecting that. Any ideas?

Smit
Comment 7 Smit Mehta 2012-06-27 07:12:29 UTC
Git commit f699376e285d3e81b79a788c32182a9b49d61edb by Smit Mehta.
Committed on 27/06/2012 at 09:11.
Pushed by smitmehta into branch 'master'.

context menu typo fix. view->preview

M  +1    -1    digikam/items/digikamimageview.cpp

http://commits.kde.org/digikam/f699376e285d3e81b79a788c32182a9b49d61edb