Bug 295721 - Impossible to change activity icon after bug 295328
Summary: Impossible to change activity icon after bug 295328
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: activities (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 302515 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-03-10 21:09 UTC by maxime.haselbauer
Modified: 2012-07-25 12:13 UTC (History)
10 users (show)

See Also:
Latest Commit: http://commits.kde.org/kactivities/393890e01fea5444a71110be9a3e1777c5e07d18
Version Fixed In: 4.8.5
Sentry Crash Report:

Attachments
Here you see the icon selected,("Actions") however it won't be applied (490.40 KB, application/octet-stream)
2012-03-10 21:09 UTC, maxime.haselbauer 		Details
see at the bottom of the screen: icons are defined for every activity but not in the activity list (557.77 KB, application/octet-stream)
2012-04-22 11:19 UTC, maxime.haselbauer 		Details
Reset Activity Icons (631 bytes, text/plain)
2012-07-25 12:13 UTC, David E. Narvaez 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description maxime.haselbauer 2012-03-10 21:09:50 UTC 
Created attachment 69472 [details]
Here you see the icon selected,("Actions") however it won't be applied

KDE 4.8.1 Kubuntu 11.10 32bit
It happen when
1) Kactivitymanagerd crashed as described in bug 295328
2) I restart my computer 
3) This time no crash message from kactivitymanagerd but:
4) The icon and name of a couple of activities deleted during the crash are not restored
5) Manually restoring the name works fine
6) Manually restoring the icon
    6.1)Selecting the icon works (see the screenshot for the "Actions" activity
    6.2)When clicking apply, it will not apply the selected icon to the activity


I have tested to selected
  _the same .png file as setted prior to the crash stated in 1)
  _another .png file
  _an svg file 
  _ system icon

Each time it will not apply 

Feel free to merge this bug with bug 295328 if, frome a code point of view it has the same origin. I have choosen to report it has a new bug since, to me, I still should be able to define icons for those activities
Comment 1 list-ener 2012-03-19 11:00:28 UTC 
Can confirm for: KDE 4.8.1 Kubuntu 11.10 64bit

But without any prior crash of kactivitymanagerd (at least not AFAIR). UI for changing icons in activity manager works, but selection is not applied.
Comment 2 David E. Narvaez 2012-03-23 13:00:59 UTC 
Hi, I can confirm this. We just had a discussion among developers and found out the root of the issue, which should be fixed for KDE 4.8.2. I'll keep this bug posted.

Thanks for your report!
Comment 3 James Cain 2012-04-02 03:07:57 UTC 
That's good news as this affects me as well. Can we confirm the fix for 4.8.2?
Comment 4 David E. Narvaez 2012-04-02 04:41:12 UTC 
Yes, bug fix was committed 10 days ago[0], so it will be available for 4.8.2. Release is this week, so I'll close this bug once we can try the fix out.

[0] https://projects.kde.org/projects/kde/kdelibs/repository/revisions/8d1d728d80ca561b8dc6058548fe57e6ee4a3120
Comment 5 David E. Narvaez 2012-04-06 09:43:24 UTC 
Confirmed on 4.8.2
Comment 6 James Cain 2012-04-06 11:19:27 UTC 
I noticed that it was fixed. Awesome!

- James

On Friday, April 06, 2012 09:43:24 AM you wrote:
> https://bugs.kde.org/show_bug.cgi?id=295721
> 
> David E. Narvaez <david.narvaez@computer.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
> Status|NEW                         |RESOLVED
>    Version Fixed In|                            |4.8.2
>          Resolution|---                         |FIXED
> 
> --- Comment #5 from David E. Narvaez <david.narvaez@computer.org> ---
> Confirmed on 4.8.2
Comment 7 maxime.haselbauer 2012-04-22 11:16:51 UTC 
Not completely fixed !
I have an activiy list widget in my kontrol toolbar at the bottom
When I apply icon to activities icon are shown in this activitiy list
When I restart the computer, icon stay defined for all activities but do not appear next to their names in the activitiy list (see screeenshot)

might be related to 295328
Comment 8 maxime.haselbauer 2012-04-22 11:19:11 UTC 
Created attachment 70565 [details]
see at the bottom of the screen: icons are defined for every activity but not in the activity list
Comment 9 David E. Narvaez 2012-04-23 03:43:04 UTC 
Hi, true, I can replicate this, but this is actually another bug. Could you please open a new bug for this? I'll be closing this one for the moment.
Comment 10 maxime.haselbauer 2012-06-23 12:35:43 UTC 
And sadly it the full bug (not applying icon on activities ) is back again since 4.8.4
Comment 11 Matteo Agostinelli 2012-06-25 08:12:31 UTC 
I can confirm this bug in 4.8.4 (Arch Linux)
Comment 12 modellbaukeller 2012-06-28 17:38:46 UTC 
I can also confirm this weird revival of that bug (no takeover of activity-icons) for 4.8.4 under Debian Testing and Unstable.
Comment 13 Maarten De Meyer 2012-07-24 16:24:17 UTC 

*** This bug has been marked as a duplicate of bug 302515 ***
Comment 14 David E. Narvaez 2012-07-24 16:30:59 UTC 
It's the other way around.
Comment 15 David E. Narvaez 2012-07-24 16:31:49 UTC 
*** Bug 302515 has been marked as a duplicate of this bug. ***
Comment 16 David E. Narvaez 2012-07-25 12:10:30 UTC 
Git commit 393890e01fea5444a71110be9a3e1777c5e07d18 by David E. Narváez.
Committed on 25/07/2012 at 14:22.
Pushed by narvaez into branch 'KDE/4.8'.

Hook Activity Manager Icons Config to Nepomuk and Write Icons

These changes were missing from the set of changes that introduced
icons config in 4.8
FIXED-IN: 4.8.5

M  +7    -0    service/ActivityManager.cpp

http://commits.kde.org/kactivities/393890e01fea5444a71110be9a3e1777c5e07d18
Comment 17 David E. Narvaez 2012-07-25 12:13:07 UTC 
Created attachment 72754 [details]
Reset Activity Icons

After getting the fix from KDE 4.8.5, you will need to reset the icons for each of your activities. If these are too many, you can use the attached script to reset them all to what you had before KDE 4.8.4.