Bug 294579 - GROUP : grouped pictures are not processed together except the first one (Renaming, Tags, Metadata, Labels, etc.)
Summary: GROUP : grouped pictures are not processed together except the first one (Ren...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-ItemGroup (show other bugs)
Version: 5.0.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 19:24 UTC by philippe.quaglia
Modified: 2016-11-09 17:19 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description philippe.quaglia 2012-02-21 19:24:25 UTC
Version:           2.5.0
OS:                Linux

When tagging a set of grouped pictures, only the first one (the one visible) is tagged. I think that all the pictures grouped beneath the visible one should be tagged, or at least a dialog should ask if we want to tag the complete group or only the visible picture.

Reproducible: Always

Steps to Reproduce:
Tag a set of grouped pictures

Actual Results:  
Only the first one is tagged

Expected Results:  
By default, all the grouped pictures should be tagged when tagging a set of grouped pictures, or may be a dialog box should ask if we want to tag the picture or the group ?
Comment 1 Marcel Wiesweg 2012-07-01 19:53:16 UTC
IMO, intuition is not clear as to whether grouped images are affected or not.
It is possible to add additional menu entries to the popups that appear on drag and drop, but there will be some smaller complications with details.
Alternatively, we can add a setup option if grouped images shall be affected by operations on the lead image. This had the advantage of clearing the situation for rating etc. as well.
It gets a bit more complex: What about the desc edit sidebar? Kipi plugins?
I believe a solution with one setup option for metadata operations can be enough, for all other cases, only the visible images will be affected, the user can always expand all groups in the view.
Opinions?
Comment 2 philippe.quaglia 2012-07-06 08:12:35 UTC
Hello,
when dragging a tag to a picture, there is a pop-up menu asking if the tag should be applied to the current picture or to all the pictures. There may be an additionnal question when we are above grouped pictures. I'm not skilled enough to see the other induced complications. However your proposal of a default setting may do the job as well.
Regards.
Comment 3 Marcel Wiesweg 2012-07-06 17:27:53 UTC
I initially planned to extend this context menu, but there are quite a few ways to edit metadata without drag and drop, be it the right sidebar, the context menu, or the icon view overlays for e.g. rating. For all these, the dragdrop menu approach will not work, or even raise the question which scope the operation actually has. There's also some implications case of a tag dragged on empty space or on a selection of pictures, where we currently offer three possibilities in the menu.
Comment 4 mnaugendre 2013-09-08 12:21:20 UTC
And I have the reverse problem: having removed tags from grouped pictures, it appears that only the 'head of group' has been affected. So these tags are still assigned to pictures that I cannot find, as they are hidden.
Comment 5 caulier.gilles 2014-09-02 07:54:17 UTC
*** Bug 249302 has been marked as a duplicate of this bug. ***
Comment 6 caulier.gilles 2016-04-28 12:41:49 UTC
*** Bug 362411 has been marked as a duplicate of this bug. ***
Comment 7 caulier.gilles 2016-07-07 04:35:44 UTC
This file still valid with last digiKam 5.0.0 ?

Gilles Caulier
Comment 8 philippe.quaglia 2016-07-14 18:25:11 UTC
Yes, I guess it is still valid, the behaviour is still exactly the same.
Comment 9 tuxflo 2016-09-13 19:49:52 UTC
Also still valid in version 5.1.0.
Comment 10 Maik Qualmann 2016-11-09 17:19:44 UTC
Git commit 5f6aa8656cf333e8949b10660407e8c8a0c0cc4f by Maik Qualmann.
Committed on 08/11/2016 at 21:11.
Pushed by mqualmann into branch 'master'.

apply patch #102005 from Simon Frei to adjust grouping behavior
FIXED-IN: 5.4.0

M  +2    -1    NEWS
M  +1    -1    app/items/digikamimageview.cpp
M  +29   -18   app/items/imagecategorizedview.cpp
M  +6    -3    app/items/imagecategorizedview.h
M  +0    -27   app/items/imageviewutilities.cpp
M  +12   -3    app/views/digikamview.cpp
M  +96   -49   app/views/tableview/tableview.cpp
M  +10   -4    app/views/tableview/tableview.h
M  +0    -24   app/views/tableview/tableview_model.cpp
M  +0    -2    app/views/tableview/tableview_model.h
M  +13   -0    libs/database/item/imageinfolist.cpp
M  +2    -1    libs/database/item/imageinfolist.h
M  +1    -0    libs/models/imagefiltermodel.h
M  +0    -1    libs/tags/tagslineeditoverlay.cpp

http://commits.kde.org/digikam/5f6aa8656cf333e8949b10660407e8c8a0c0cc4f