Bug 294217 - Make add face persistent, and add box by single click instead of drawing [patch]
Summary: Make add face persistent, and add box by single click instead of drawing [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Engine (show other bugs)
Version: 2.5.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 10:00 UTC by 20120808_bugs.kde.org
Modified: 2015-06-17 12:10 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.11.0
Sentry Crash Report:


Attachments
Suggested patch (5.75 KB, patch)
2012-07-24 08:41 UTC, Kristian Karl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description 20120808_bugs.kde.org 2012-02-16 10:00:50 UTC
Version:           2.5.0 (using KDE 4.8.0) 
OS:                Linux

Viewing a picture with several faces, manually adding face tags takes quite a few clicks. The process could be tweaked a bit with what come across as small changes:
 a) clicking 'add a face tag' changes to 'switch to add face tags mode'. now one need not click 'add a face tag' for each face in the same image

 b) a box (for a face tag) is already placed either upon mouse click or automatically in the center of the image. now the user needs only to move the box to the face, resizing the box accordingly

 c) subsequent boxes can now be created merely by clicking. the initial box size is that of the previously used box sized (likely i guess that faces in the same picture would be approximately the same size)

 d) this may offer a 'manually tag faces' mode so that button would not need to be clicked for each viewed photo

Reproducible: Didn't try

Steps to Reproduce:
find two pictures with faces to tag; for example, a picture with three faces then a picture with two faces

Actual Results:  
 1) click 'add a face tag'
 2) draw a box around the first face
 3) click 'add a face tag'
 4) draw a box around the second face
 5) click 'add a face tag'
 6) draw a box around the third face

 7) 'forward' to next picture

 8) click 'add a face tag'
 9) draw a box around the first face
10) click 'add a face tag'
11) draw a box around the second face

Expected Results:  
 1) click 'add a face tag' (which is either 'add face tags' or 'switch to face tagging mode')

 2) click the first face; box is drawn automatically
 3) adjust box as needed

 4) click second face
 5) click third face

 6) 'forward' to next picture

 7) click first face
 8) click second face

OS: Linux (x86_64) release 3.0.0-16-generic-tuxonice
Compiler: gcc
Comment 1 20120808_bugs.kde.org 2012-02-16 10:13:59 UTC
Only a savings of three steps? from eleven to eight in this example? not enough savings? How about again showing mouse movements (I have not seen a keyboard shortcut for 'add a face tag'):


Actual Results:
 1) move mouse toward 'add a face tag' button
 2) click 'add a face tag'
 3) move mouse down toward face
 4) draw a box around the first face
 5) move mouse up toward 'add a face tag' button
 6) click 'add a face tag'
 7) move mouse down toward face
 8) draw a box around the second face
 9) move mouse up toward 'add a face tag' button
10) click 'add a face tag'
11) move mouse down toward face
12) draw a box around the third face

13) 'forward' to next picture

14) move mouse up toward 'add a face tag' button
15) click 'add a face tag'
16) move mouse down toward face
17) draw a box around the first face
18) move mouse up toward 'add a face tag' button
19) click 'add a face tag'
20) move mouse down toward face
21) draw a box around the second face


Expected Results:  
 1) move mouse up toward 'add a face tag' button
 2) click 'add a face tag'

 3) move mouse down toward faces
 4) click the first face; box is drawn automatically
 5) adjust box as needed

 6) move mouse toward next face
 7) click second face
 8) move mouse up toward next face
 9) click third face

10) 'forward' to next picture

11) move mouse toward next face
12) click first face
13) move mouse toward next face
14) click second face
Comment 2 Kristian Karl 2012-07-24 08:41:39 UTC
Created attachment 72719 [details]
Suggested patch

I also feel that the proposed workflow will help when manually face tagging.
I made a suggested patch that I think may work, but I would like to get some feed back.

What I did was changing the 'Add a Face Tag' button into a toggle button instead, pretty much as the 'Show Face Tags' toggle button works.
Comment 3 Marcel Wiesweg 2012-09-22 12:33:47 UTC
Nit-picking, I would like to add that "adjust box as needed" is two steps, drag upper left corner, drag lower left corner, after each single click.
Comment 4 Kristian Karl 2014-02-08 13:01:59 UTC
See also #329433
Comment 5 Kristian Karl 2014-02-08 13:02:38 UTC
I meant bug https://bugs.kde.org/show_bug.cgi?id=329433
Comment 6 caulier.gilles 2014-08-24 11:54:33 UTC
Kristian,

Can you update your patch with current implementation from git/master (currently next 4.3.0) ?

Thanks in advance

Gilles Caulier
Comment 7 Kristian Karl 2014-08-24 18:41:15 UTC
I just update https://bugs.kde.org/show_bug.cgi?id=329433
It's the same patch, that I proposed for this bug.
Comment 8 caulier.gilles 2015-05-10 21:00:35 UTC
As patch from bug #329433 is already applied to git/master, and as explained in comment #7, the patch is the same, we can close this file now.

Gilles Caulier
Comment 9 mr.mahon.pl 2015-06-17 08:09:08 UTC
Wouldn't adding a keyboard shortcut for "Add a face tag" help a lot? 
I think it would speed things up a lot:

1. press the key shortcut
2. click one corner of the box
3. click the opposite corner of the box
4. [next face]  press the key shortcut
5. click one corner of the box
6. click the opposite corner of the box
etc. [alternatively: moving to the next picture with the keyboard]

With mouse in one hand and keyboard under the other it would be really smooth.
Comment 10 Kristian Karl 2015-06-17 09:05:40 UTC
You should be able to do the following.
When ready to add a face tag:
1. Press and hold the Ctrl-key
2. Click and hold left mouse button where you want the corner of your face tag
3. Move the mouse to the other corner, and release the mouse button.

Did this help you?
Comment 11 mr.mahon.pl 2015-06-17 09:22:00 UTC
(In reply to Kristian Karl from comment #10)
> You should be able to do the following.
> When ready to add a face tag:
> 1. Press and hold the Ctrl-key (...)
> 
> Did this help you?

I forgot about this, even though I used it a lot.
But then I encounter a problem:

After tagging a face, when I start tagging another one, the previous box(es) dissapears. 
I need to disable the "show face tags" mode and re-enable it to see the boxes again.

But I think it's a different error.
Thanks for the help!
Comment 12 mr.mahon.pl 2015-06-17 12:10:16 UTC
> I forgot about this, even though I used it a lot.
> But then I encounter a problem:
> 
> After tagging a face, when I start tagging another one, the previous box(es)
> dissapears. 
> I need to disable the "show face tags" mode and re-enable it to see the
> boxes again.
> 
> But I think it's a different error.
> Thanks for the help!

I checked and yes, it's a different error:
https://bugs.kde.org/show_bug.cgi?id=334244#c8