Created attachment 84352 [details] Patch implementing the feature I always add Face Tags to my images. It's a great feature. However great the Face Detection mechanism is, it's not yet perfect, so I need to do a lot of manual adding of Face Tags. The workflow in Digikam today is a bit awkward today. I need to click the "Add a Face Tag" button for every Face Tag I need to add in an image. This is quite unergonomic, and tiresome. The patch I provided, enables a user to add a Face Tag to an image by just Ctrl+left clicking on the image where the Face Tag should be. This facilitates the process of adding many Face Tags.
Any ideas how to make this feature discoverable? Otherwise it seems fine for me.
Why not to open this shortcut to be customizable in KDE application config dialog ? Tips dialog at startup is also a good way to promote this feature. We have also a text file which group all know keyboard shortcut where we can register it : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/project/KEYSHORTCUTS Gilles
I think that a tool tip when hovering over the "Add a Face Tag" button could also be helpful.
Kristian, Can you update your patch using current code from git/master (next digiKam 4.3.0) Thanks in advance Gilles Caulier
Created attachment 88405 [details] Update for latest core on master: 42754c4452bda70707d16134e20a277441550ae0
Maik, This is another candidate patch to include to 4.9.0, i think... Gilles
Created attachment 91855 [details] Updated patch
Git commit c35027e5069e870888c819330b0c55bf42c76c7e by Maik Qualmann. Committed on 02/04/2015 at 16:38. Pushed by mqualmann into branch 'master'. apply patch #91855 from Kristian Karl to manually adding a face with the Ctrl + left mouse button FIXED-IN: 4.9.0 M +2 -1 NEWS M +10 -0 app/views/imagepreviewview.cpp M +1 -0 app/views/imagepreviewview.h http://commits.kde.org/digikam/c35027e5069e870888c819330b0c55bf42c76c7e
Git commit 77991dd845f18e7cd157c78afea47e7481533777 by Gilles Caulier. Committed on 02/04/2015 at 20:51. Pushed by cgilles into branch 'master'. libkface is optional. Only compile code relevant of facegroup if dependency is resolved. M +3 -2 app/views/imagepreviewview.cpp http://commits.kde.org/digikam/77991dd845f18e7cd157c78afea47e7481533777
Git commit 59a263e2cb247a0c3e0afdfd02ddff26a850760f by Gilles Caulier. Committed on 27/03/2015 at 13:42. Pushed by cgilles into branch 'frameworks'. backport commits #c35027e5069e870888c819330b0c55bf42c76c7e and #77991dd845f18e7cd157c78afea47e7481533777 from git/master to frameworks branch M +11 -0 app/views/imagepreviewview.cpp M +1 -0 app/views/imagepreviewview.h http://commits.kde.org/digikam/59a263e2cb247a0c3e0afdfd02ddff26a850760f