Bug 292041 - When using the logger integration it's hard to see when the chat starts
Summary: When using the logger integration it's hard to see when the chat starts
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: text-ui (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: Future
Assignee: Daniele E. Domenichelli
URL:
Keywords:
: 320710 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-20 14:48 UTC by David Edmundson
Modified: 2013-06-18 17:46 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.7.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2012-01-20 14:48:15 UTC
Using the renkoo theme history messages look the same as messages just recieved/sent.

We need to find out what does Adium does, check I'm not missing any flags on the styles.

We do set scrollback messages to have different styles which can be seen in teh pushpin theme, but given the Adium theme "spec" there's different variants. Alternately we can edit the renkoo theme to cross out the messages or something. OR display a status message to say "chat has opened" (or equivalent).

I'd like an early simple patch rather than waiting for the new QML sexiness (probably 0.5 or later)
Comment 1 David Edmundson 2013-03-22 14:19:47 UTC
*** Bug 316738 has been marked as a duplicate of this bug. ***
Comment 2 Daniele E. Domenichelli 2013-03-22 14:50:33 UTC
Taking this, since I have a patch almost working -> http://wstaw.org/m/2013/03/22/snapshot130.png
Assigning to 0.7 since it requires a new i18n string, but eventually we can add it without that string, adding a status message with the date only, and we can change this as soon as we branch.
What do you think?
Comment 3 Daniele E. Domenichelli 2013-03-23 22:42:23 UTC
[15:52:36] <drdanz> d_ed: do you like the idea of having _just the date_ as status message?
[15:55:37] <d_ed_> yes

So I'm changing this as blocking for 0.6.0 :P
Comment 4 David Edmundson 2013-04-01 16:27:38 UTC
There was a patch on this, I rejected it for being too large and hacky (and hacky was the only thing that would work, in the current design) .

I'm tidying this up for 0.7.0, we can fix this then. 

I don't think this is so critical it should block the release.
Comment 5 David Edmundson 2013-06-04 12:01:15 UTC
*** Bug 320710 has been marked as a duplicate of this bug. ***
Comment 6 David Edmundson 2013-06-12 20:57:19 UTC
Git commit 17a7c522f43b0e07170fb33a1f982c2ab64a0872 by David Edmundson.
Committed on 12/06/2013 at 22:54.
Pushed by davidedmundson into branch 'master'.

Make sure to set messages as history where applicable

This solves a bug in which messages in history could still group together with new messages

M  +10   -2    lib/adium-theme-view.cpp

http://commits.kde.org/telepathy-text-ui/17a7c522f43b0e07170fb33a1f982c2ab64a0872
Comment 7 Daniel Vrátil 2013-06-18 17:46:58 UTC
Git commit 7a3719232c63a1830c561fa119fb65ed6e5393e3 by Dan Vrátil.
Committed on 18/06/2013 at 19:21.
Pushed by dvratil into branch 'master'.

When date of a message in scrollback changes, add a status message with the new date

REVIEW: 111094
FIXED-IN: 0.7.0

M  +14   -2    lib/chat-widget.cpp

http://commits.kde.org/telepathy-text-ui/7a3719232c63a1830c561fa119fb65ed6e5393e3