Bug 282548 - Add Singapore
Summary: Add Singapore
Status: RESOLVED FIXED
Alias: None
Product: kdepimlibs
Classification: Applications
Component: kholidays (show other bugs)
Version: 4.7
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: John Layt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-22 11:19 UTC by Ray Rashif
Modified: 2016-10-20 21:43 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8.1


Attachments
Proposed libkholidays plan2 file for Singapore (2.22 KB, application/octet-stream)
2011-09-22 11:19 UTC, Ray Rashif
Details
Singapore public holidays for 2012 and 2013 (1.48 KB, patch)
2012-01-27 03:37 UTC, Matthias
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ray Rashif 2011-09-22 11:19:52 UTC
Created attachment 63854 [details]
Proposed libkholidays plan2 file for Singapore

Version:           4.7 (using KDE 4.7.1) 
OS:                Linux

All national holidays (holidays for everyone) in Singapore are considered "Public Holidays", including religious ones.

Students of Primary and Secondary levels enjoy "School Holidays" that include term/semester breaks. These holidays are not for the working public, or students of tertiary level and beyond (who do have term/semester breaks).

Cultural observences are not holidays, but are marked on the calender.

A few (usually just one to two but may be more in some years) of the public holidays do not have a fixed recurring date and depend on external factors. The government marks unconfirmed dates officially (that are printed as such) and issues updates or confirmation through the media at a later time. This may apply to non-holiday observences as well.

Holidays that fall on a Sunday will roll over to a holiday on the next Monday. Both the days are marked on the calender, so I am unsure if this translates perfectly to "shift to monday if sunday".

I have attached a plan(2) file but it should not be committed verbatim. The syntax is not well-documented and there are different styles among the distributed files, for eg. "minus 2" vs. "minus 2 days", "shift to monday if sunday" vs. "$someconditional". I am also unsure what "weekend on $someday" means over simply "$someday". I wanted to add in the term/semester breaks for schools, but was not confident that the "plus $days" syntax would be correct.

The primary sources for the year of 2011:

http://www.mom.gov.sg/employment-practices/employment-rights-conditions/leave-and-holiday/Pages/PublicHolidays2011.aspx

http://www.moe.gov.sg/schools/terms-and-holidays/

There are iCalender, XML and HTML files offered, so it would be good if in the future libkholidays could parse one or more of such formats.

Reproducible: Didn't try

Steps to Reproduce:
N.A

Actual Results:  
N.A

Expected Results:  
N.A

N.A
Comment 1 Matthias 2012-01-27 03:37:30 UTC
Created attachment 68220 [details]
Singapore public holidays for 2012 and 2013
Comment 2 Matthias 2012-01-27 03:39:45 UTC
I installed KDE 4.8 and found that it does not come with the public holidays for Singapore. I created a file (see #Comment 1) for 2012 and 2013 which could be merged with that of the first post.

Sources are:
http://www.mom.gov.sg/employment-practices/employment-rights-conditions/leave-and-holiday/Pages/PublicHolidays2012.aspx

http://www.officeholidays.com/countries/singapore/2013.asp
Comment 3 Matthias 2012-01-27 03:41:15 UTC
Comment on attachment 68220 [details]
Singapore public holidays for 2012 and 2013

I installed KDE 4.8 and found that it does not come with the public holidays for Singapore. I created a file for 2012 and 2013 which could be merged with that of the first post.

Sources are:
http://www.mom.gov.sg/employment-practices/employment-rights-conditions/leave-and-holiday/Pages/PublicHolidays2012.aspx

http://www.officeholidays.com/countries/singapore/2013.asp
Comment 4 Christophe Marin 2012-01-29 11:53:06 UTC
(In reply to comment #3)
> (From update of attachment 68220 [details])
> I installed KDE 4.8 and found that it does not come with the public holidays
> for Singapore. I created a file for 2012 and 2013 which could be merged with
> that of the first post.

Looks good but your file doesn't include the cultural and school days that were in Ray's file. Is that on purpose ?
Comment 5 Matthias 2012-01-29 12:13:40 UTC
I think the cultural days are a bit subjective. I'm not sure if anybody observes "April Fool's Day" for example.

I left out the school holidays, because different school types have different holidays (see link provided by Ray) and I think that gets a bit confusing and overloads the calendar. Maybe a second file with school holidays would be nice. This way they are optional and it is up to the user to enable or disable them. But I think no other country calendar has that.

To answer your question; my personal opinion is that it is better to show only the official public holidays.
Comment 6 Christophe Marin 2012-01-29 13:00:58 UTC
Git commit 6e007fe3218a206e6bf59ff5473cd96648fbacc4 by Christophe Giboudeaux.
Committed on 29/01/2012 at 13:59.
Pushed by cgiboudeaux into branch 'master'.

Add public holiday for Singapore.
FIXED-IN: 4.8.1

A  +49   -0    kholidays/holidays/plan2/holiday_sg_en-gb

http://commits.kde.org/kdepimlibs/6e007fe3218a206e6bf59ff5473cd96648fbacc4
Comment 7 Christophe Marin 2012-01-29 13:01:34 UTC
Git commit 3ffe6123e56843113b66506ce5b1cf677fa44323 by Christophe Giboudeaux.
Committed on 29/01/2012 at 13:59.
Pushed by cgiboudeaux into branch 'KDE/4.8'.

Add public holiday for Singapore.
FIXED-IN: 4.8.1
(cherry picked from commit c4b2c8558ab778bc0f681388e59fb168b7d39cc3)

A  +49   -0    kholidays/holidays/plan2/holiday_sg_en-gb

http://commits.kde.org/kdepimlibs/3ffe6123e56843113b66506ce5b1cf677fa44323
Comment 8 Matthias 2012-01-29 13:04:59 UTC
Thank you!
Comment 9 Christoph Feck 2016-10-20 21:43:16 UTC
*** Bug 251318 has been marked as a duplicate of this bug. ***