Bug 251318 - New Wish - Add Holiday for Malaysia and Singapore
Summary: New Wish - Add Holiday for Malaysia and Singapore
Status: REOPENED
Alias: None
Product: kdepimlibs
Classification: Applications
Component: kholidays (show other bugs)
Version: 4.5
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: John Layt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-15 13:50 UTC by Michalng
Modified: 2022-12-11 14:04 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Proposed libkholidays plan2 file for Singapore (English) revised (2.42 KB, application/octet-stream)
2011-09-24 11:16 UTC, Ray Rashif
Details
Proposed libkholidays plan2 file for Singapore (Malay) (2.40 KB, application/octet-stream)
2011-09-24 11:18 UTC, Ray Rashif
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michalng 2010-09-15 13:50:42 UTC
Version:           4.5 (using KDE 4.5.1) 
OS:                Linux

Add holidays for country "Malaysia" and "Singapore", as they are currently not in the list.

Note: referred from Bug 250778 (https://bugs.kde.org/show_bug.cgi?id=250778) to here.

Reproducible: Didn't try

Steps to Reproduce:
Not Applicable

Actual Results:  
Not Applicable

Expected Results:  
Not Applicable


Official website for Singapore Holiday:
http://www.mom.gov.sg/employment-practices/employment-rights-conditions/leave-and-holiday/Pages/public-holidays.aspx
http://www.mom.gov.sg/employment-practices/employment-rights-conditions/leave-and-holiday/Pages/public-holidays-2010.aspx
http://www.mom.gov.sg/employment-practices/employment-rights-conditions/leave-and-holiday/Pages/PublicHolidays2011.aspx

Unofficial website for Singapore Holiday
http://en.wikipedia.org/wiki/Public_holidays_in_Singapore


Unofficial website for Malaysia Holiday
http://en.wikipedia.org/wiki/Public_holidays_in_Malaysia
Comment 1 John Layt 2010-09-15 16:56:17 UTC
Thanks Michal!

Those look a complicated set of holidays :-)  The biggest problem is we don't have Chinese, Buddhist or Hindu lunar calendar implementations yet, and our Islamic calendar is slightly inaccurate, so we'll have to hard-code fixed dates for now.

I assume we will need English, Malay and Chinese translations for the holidays?  Are the translations on Wikipedia accurate?

Once I have an English file ready I'll get you to have a look at it.
Comment 2 Michalng 2010-09-16 00:54:02 UTC
Sure, 
please forward the English file when ready, 
I'm glad to be able to help :D
Comment 3 Ray Rashif 2011-09-24 11:16:50 UTC
Created attachment 63910 [details]
Proposed libkholidays plan2 file for Singapore (English) revised
Comment 4 Ray Rashif 2011-09-24 11:18:05 UTC
Created attachment 63912 [details]
Proposed libkholidays plan2 file for Singapore (Malay)
Comment 5 Ray Rashif 2011-09-24 11:21:55 UTC
I don't know why this didn't come up in my searches before I filed http://bugs.kde.org/show_bug.cgi?id=282548 but I'm going to attach my revised plan file here for Singapore. Didn't want to check out the repo just for this, so I've attached the files to be committed.

I've verified the Malay translation and even though it's my second language, I'm a little rusty. Ammendment is encouraged by other able individuals, but for now this is good enough.

The "shift to monday if sunday" logic does not show up nicely, as it's not like our calenders where both the Sunday and Monday are marked. In the calender plasmoid/widget only the Monday is marked.
Comment 6 Denis Kurz 2016-09-24 20:55:14 UTC
This bug has only been reported for versions before 4.14, which have been unsupported for at least two years now. Can anyone tell if this bug still present?

If noone confirms this bug for a Framework-based version of kdepim (version 5.0 or later, as part of KDE Applications 15.08 or later), it gets closed in about three months.
Comment 7 Ray Rashif 2016-10-20 08:38:03 UTC
This could definitely be closed since https://bugs.kde.org/show_bug.cgi?id=282548 shows it was implemented.
Comment 8 Christoph Feck 2016-10-20 21:43:16 UTC

*** This bug has been marked as a duplicate of bug 282548 ***
Comment 9 ramchyld 2022-12-10 21:02:40 UTC
Hi,

I'm writing to note that this bug is only partially resolved. 

There is still no holidays for Malaysia, only Singapore. 

Public holidays for Malaysia can be seen in the Google calendar: https://calendar.google.com/calendar/u/0/embed?src=en.malaysia%23holiday@group.v.calendar.google.com&ctz=Asia/Kuala_Lumpur

Thanks.
Comment 10 Ray Rashif 2022-12-11 06:50:24 UTC
After more than six years I must agree that this was indeed mistakenly closed, perhaps influenced by my last comment (I apologize if so). There was resolution for Singapore only in the one other duplicate bug, but nowhere was there any update for Malaysia, which was included in the original intent and scope of this ticket more than 12 years ago.
Comment 11 ramchyld 2022-12-11 14:04:24 UTC
Follow-up in Bug 462867