Bug 279128 - Transform page bar into a toolbar
Summary: Transform page bar into a toolbar
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.13
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
: 267790 288259 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-08-02 06:37 UTC by Victor Varvaryuk
Modified: 2018-01-29 22:25 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.0
Sentry Crash Report:


Attachments
Transform page bar into a toolbar. This will allow moving the page bar near other toolbars (79.63 KB, image/png)
2011-08-02 06:37 UTC, Victor Varvaryuk
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Varvaryuk 2011-08-02 06:37:49 UTC
Created attachment 62451 [details]
Transform page bar into a toolbar. This will allow moving the page bar near other toolbars

Version:           0.13 (using KDE 4.7.0) 
OS:                Linux

Suggestion for improvement - transform page bar into a toolbar. This will allow moving the page bar near other toolbars. Currently page bar is on bottom, taking a lot of space on wide screens.

Reproducible: Didn't try



Expected Results:  
Page bar to be movable near other toolbars.
Comment 1 Jonathan Marten 2011-12-14 17:32:44 UTC
*** Bug 288259 has been marked as a duplicate of this bug. ***
Comment 2 Jonathan Marten 2011-12-16 14:58:39 UTC
Patch to implement submitted at https://git.reviewboard.kde.org/r/103427/
Comment 3 Albert Astals Cid 2012-01-31 18:56:15 UTC
*** Bug 267790 has been marked as a duplicate of this bug. ***
Comment 4 Albert Astals Cid 2012-01-31 18:56:26 UTC
Git commit 06326f731162f9b0f0088f73d3fdf8d6c21bc3d3 by Albert Astals Cid, on behalf of Jonathan Marten.
Committed on 31/01/2012 at 19:48.
Pushed by aacid into branch 'master'.

Allow the page number selector to be added to the toolbar

Ok, this is not really the review Jonathan did, i did rewrite the code partially because i did not really
want to have a new observer, but the code is heavily inspired in his patch.

Also the page number selector is not in the toolbar as the review had, it'd be silly to have it in both places
by default, so if you want to have it you have to go, edit the toolbar and add the "Page Number" action to it.

REVIEW: 103427
FIXED-IN: 4.9.0

M  +14   -2    part.cpp
M  +1    -0    part.h
M  +120  -74   ui/minibar.cpp
M  +31   -8    ui/minibar.h

http://commits.kde.org/okular/06326f731162f9b0f0088f73d3fdf8d6c21bc3d3