Bug 264841 - minimum icon size for the places-panel
Summary: minimum icon size for the places-panel
Status: RESOLVED WORKSFORME
Alias: None
Product: kfile
Classification: Unmaintained
Component: kfileplacesview (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Lukáš Tinkl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-30 13:36 UTC by Peter Paulsen
Modified: 2018-04-10 21:00 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Paulsen 2011-01-30 13:36:57 UTC
Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

When I plug in some removable media it might happen that the icons in the places-panel shrink to a tiny 22x22 or even 16x16 size because the used description for the new medium is very long (e.g. 1010,95 MiB Wechseldatenträger" - who came up with that word... why not just "USB-Stick" but that's another report - or when the CD/DVD has a very long name). I'd like to prevent that because I cannot deal with such small icons. For I am sure I am not the only one having difficulties with tiny icons I propose to let the user set a minimum size for those places-panel icons. I have no problem with a horizontal scrollbar or truncated text (best with a tooltip showing the whole name but I guess I could live without) but please not that tiny icons.

Reproducible: Always
Comment 1 Kevin Ottens 2011-02-01 19:14:21 UTC
Would that be ok with you if it never went below the icon size set as default for toolbars? It's user changeable.
Comment 2 Christoph Feck 2012-09-23 01:14:10 UTC
Git commit 0a0231a340a21480207d967beb695a821155b58c by Christoph Feck.
Committed on 23/09/2012 at 03:08.
Pushed by cfeck into branch 'KDE/4.9'.

Respect Small icon size as minimum size in old places panel
Related: bug 182089

M  +1    -1    kfile/kfileplacesview.cpp
M  +3    -0    kfile/kfilewidget.cpp

http://commits.kde.org/kdelibs/0a0231a340a21480207d967beb695a821155b58c
Comment 3 Christoph Feck 2012-09-25 21:01:41 UTC
Git commit 8620d024d6819a78232ff9edf90766b77c43acde by Christoph Feck.
Committed on 25/09/2012 at 22:54.
Pushed by cfeck into branch 'KDE/4.9'.

Fix KFilePlacesView::sizeHint() to use correct size and margins

FIXED-IN: 4.9.2
Related: bug 307359, bug 182089

M  +1    -1    kfile/kfileplacesview.cpp

http://commits.kde.org/kdelibs/8620d024d6819a78232ff9edf90766b77c43acde
Comment 4 Christoph Feck 2012-09-25 21:05:20 UTC
Since KDE 4.9.2, the mimimum icon size of the panel respects the "Small" icon size setting of System Settings, see also bug 307359.

I believe there should be no separate minimum size configuration for the panel, but keep this open to collect other opinions.
Comment 5 Peter Paulsen 2012-09-25 21:16:23 UTC
Thanks for fixing this, Christoph. You are right, since there is already a minimum size for icons, the file dialog "just" needs to use it, no need for another configuration option (though I also like Kevin's proposal).
Comment 6 Nate Graham 2018-04-09 19:36:38 UTC
Any reason to keep this open?
Comment 7 Nate Graham 2018-04-10 19:19:32 UTC
Christoph, is this fixed now with your minimum size patch?
Comment 8 Nate Graham 2018-04-10 19:32:24 UTC
*** Bug 339662 has been marked as a duplicate of this bug. ***
Comment 9 Christoph Feck 2018-04-10 21:00:35 UTC
Reporter confirmed it works for him, see comment #5.