Bug 259335 - Folder view drag & drop regression when dolphin navigation set to double-click.
Summary: Folder view drag & drop regression when dolphin navigation set to double-click.
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-folderview (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 261289 264505 264751 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-12-09 16:06 UTC by Clint
Modified: 2011-03-31 18:07 UTC (History)
19 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Clint 2010-12-09 16:06:37 UTC
Version:           unspecified (using KDE 4.5.85) 
OS:                Linux

When using dolphin's 'double-click' to open files/folders, multiple file selection drag & drop functionality for folder view widgets is broken. If you change dolphin to single-click, intended functionality is restored.

Reproducible: Didn't try

Steps to Reproduce:
1. Dolphin -> Settings menu -> Configure dolphin -> Navigation tab.
2. Select 'double-click to open files/folders'.
3. Group a few files/folders in widget and attempt to drag drop with cursor to another folder view/dolphin file manager.

Actual Results:  
The cursor selection of multiple items 'resets' hence unable to drag & drop.


Regression started with 4.5.80 and is still present in 4.5.85.
Comment 1 mzneverdies 2010-12-09 16:10:11 UTC
Can confirm on Arch [kde-unstable] 4.5.80 and 4.5.85.
Comment 2 Kiril Vladimiroff 2010-12-10 19:26:04 UTC
Same here on my Arch with KDE 4.5.85, too.
Comment 3 Anne-Marie Mahfouf 2010-12-10 21:00:34 UTC
Confirmed. When Dolphin is set to Double-click for navigation then it's impossible to select anything in Folderview. It's then impossible to drag stuff from Folderview.
trunk kdebase revision 1205142
Comment 4 Clint 2010-12-16 10:47:39 UTC
Any chance we could expect this targeted for the 4.6 RC?
Comment 5 Vladimír Matěna 2010-12-24 14:40:07 UTC
Still present in 4.5.90 (4.6-RC1)
Comment 6 markuss 2010-12-29 15:18:24 UTC
*** Bug 261289 has been marked as a duplicate of this bug. ***
Comment 7 Clint 2011-01-06 09:27:57 UTC
Still present in 4.5.95 and to be honest I can't imagine WHY?
Comment 8 Patrizio Bassi 2011-01-07 14:02:31 UTC
unfortunately i can confirm rc2 is still bugged.
Comment 9 Nikos Chantziaras 2011-01-09 22:20:32 UTC
Does it work correctly when you configure "double click" globally in system settings?  (Input Devices -> Mouse).
Comment 10 markuss 2011-01-09 23:29:41 UTC
(In reply to comment #9)
> Does it work correctly when you configure "double click" globally in system
> settings?  (Input Devices -> Mouse).

No.
Comment 11 Clint 2011-01-18 07:02:27 UTC
It would be a shame if this was not fixed for the 4.6 release... considering the folderview widget is displayed by default on every new install... 

Any chance we could have some light shed on this by a dev?
Comment 12 TR Reardon 2011-01-25 19:24:19 UTC
Still broken on 4.6RC
Comment 13 Dave M 2011-01-27 00:29:24 UTC
Still broken in the release version of KDE 4.6
Comment 14 Dario Andres 2011-01-29 17:41:34 UTC
*** Bug 264505 has been marked as a duplicate of this bug. ***
Comment 15 incarus6 2011-01-29 17:52:27 UTC
*** Bug 264751 has been marked as a duplicate of this bug. ***
Comment 16 Aaron J. Seigo 2011-01-30 01:41:28 UTC
"Still present in 4.5.95 and to be honest I can't imagine WHY?"

that's an easy one to answer: because no one (including the people commenting on this report) contributed a patch to fix it.

our resources are limited such that we can't get to every bug and regression in such a finite amount of time. that double click isn't the default setting only lowered the odds (and making the "it's on every install by default" argument a moot point).

in any case, i'm taking a look at it now. it's just a bit discouraging to come to look at a bug report to start working on it and see these kinds of comments. :/

maybe at some point in the future my days will have 48 hours and i'll have 8 hands and 4 sets of eyes. until them, patience is appreciated.
Comment 17 markuss 2011-01-30 02:07:50 UTC
Yay! \o/ Aaron <3 :-)
Comment 18 TR Reardon 2011-01-30 02:10:18 UTC
Ok, then implicitly the feedback is "why on earth is double-click NOT the default behavior?"  

Just more KDE-being-KDE-for-KDE's-sake

+R
Comment 19 Aaron J. Seigo 2011-01-30 02:29:02 UTC
@TR Reardon: "Just more KDE-being-KDE-for-KDE's-sake"

really? that's your first bit of input on this report, even after it's been fixed? what a pathetic, rotten attitude. 

if nothing else, it has convinced me that i'm done working on software in my spare time for the weekend. feel free to take responsibility for the bugs that go unfixed as a result.

and to answer your question: it's because it is proven to have better usability for most people.
Comment 20 Clint 2011-01-30 03:47:16 UTC
First up, thanks Aaron for your comments and coding contributions. 

Please don't confuse my comments as being ungrateful - but I was perhaps impatient. My only niggling issue here is that this was confirmed for ~7 weeks with no official input/acknowledgment. If a dev is short on time or the regression is not as simple a fix as it should be then a short comment informing us of this could encourage others to take a look at the code and hopefully more patches will get submitted?

Thanks again.
Comment 21 Aaron J. Seigo 2011-01-30 04:20:13 UTC
"If a dev is short on time or the regression is not as simple a fix as it should be then a short comment informing us of this could encourage others to take a look at the code and hopefully more patches will get submitted?"

i get somewhere between 50 and 100 bugs.kde.org emails _per day_, depending on the day, and these days i'm only subscribed to the ones related to plasma. i already spend, quite literally, as much time as i reasonably can doing bug triage. and i have other responsibilities as well, with people happy to be unhappy with me if those don't get done. ;)

we have a few people who help out with bug triage and they are absolute heroes. more would be wonderful.

but seriously, it's not like these bugs go unfixed (or uncommented on) because we don't care or aren't aware that it'd be nice to comment on each report at each release milestone. it's seriously an issue of manpower.

btw, Anne-Marie is a plasma developer and she did comment on this one.
Comment 22 Aaron J. Seigo 2011-01-30 04:27:47 UTC
"encourage others to take a look at the code and hopefully more patches will get submitted"

another bit of feedback on this idea: we do, pretty regularly, ask for patches and involvement. a lot of the time we get back snarky remarks about how we're just always asking for people to fix it themselves or "be quiet" (which is not what we are suggesting when we ask people to get involved and help fix things). 

so there is no particularly great choice when it comes to dealing with bugs.kde.org, or more specifically, the people on the other end of bugs.kde.org: pretty much no matter what we do other than "fix it NOW" there's someone out there who'll be sure that i get my daily dose of 5-10 complaints by email. it's pretty unenjoyable to be on the receiving end of that year after year. no amount of "wow, we appreciate your work/efforts" really makes up for it, to be honest.

fortunately, we do get a reasonable number of fixes by asking for participation, though certainly it's a numbers game: ask 100 times and get 2-3 patches. and there are a good number of truly nice people around here as well. and as i get to know who they are, i tend to spend more time on issues they report, for what should be obvious reasons.

and in this particular case, one might have hoped that if there was 7 weeks of no fixes that someone who was affected by this and was hoping for a fix would have taken the initiative, maybe asked where to start looking. that's perhaps as realistic as having expected me to have fixed it sooner myself, though.
Comment 23 Patrizio Bassi 2011-01-30 10:44:19 UTC
as an ex-dev of several open source projects i know what Aaron means, and how it may hurt to read some kind of complains while a simple "thank you" would be enough.

of course from user point of view, with such settings, it's normal to think "how the hell they didn't notice and spend time on this", but there are several way to say the same thing, keeping respect for free devs.

from my side i would like to thank Aaron for the fix, asking the svn revision link, so i can backport to 4.6.0 and fill a bug for this in gentoo bugzilla before it gets flooded.

stay strong
Comment 24 Beat Wolf 2011-01-30 10:55:16 UTC
jeah i would like to thank aaron too :) but you probably know that 99% of people absolutely love the work you do. Sadly there is no ban functionality for bugzilla, so we have to endure those trolls that only have one thing in mind, destroy the kde project by discouraging the developers. don't let them succeed!
Comment 25 Will Stephenson 2011-02-03 22:02:29 UTC
40e65658 is the commit that fixed this in KDE/4.6 branch.
Comment 26 Will Stephenson 2011-02-03 22:14:15 UTC
Patch applied to openSUSE KDE 4.6 packages.
Comment 27 Patrizio Bassi 2011-02-04 10:52:04 UTC
Hi Will, can you give me a link to web git? or patch?

i can't find the commit id....me dumb :(
Comment 28 Kevin Brubeck Unhammer 2011-02-04 12:21:04 UTC
Patrizio, I believe http://quickgit.kde.org/index.php?p=kde-baseapps.git&a=summary is the repository, from there

    git log --stat plasma/applets/folderview/

gives some commit messages that seem likely :-)

(all the other applets seem to be in another repository, so I guess that might be confusing)
Comment 29 Patrizio Bassi 2011-02-04 13:49:08 UTC
yes but at the moment i don't have the git tool thus i cannot check from the web!
Comment 31 boeroboy 2011-03-31 18:07:05 UTC
Just got the fix across entropy in my Sabayon machine.  Thanks for getting on it, devs.  KDE rocks and I'd still use a buggy KDE over GDM (no disrespect to the Gnome folks).  Your time is appreciated.