Version: unspecified (using Devel) OS: Linux In KDE 4.5.0 only label or flag is supported. Add support for both flag and label to keyboard layout indicator Reproducible: Always
I second this request. The default font color is dark which is hard to see on dark plamsa themes. Using only flags is difficult when you have multiple variants of the same layout eg (us,us-dvp).
There's a shadow which should help with contrasting text. If it does not work right we might want to improve shadowing. Also you can change the label text when using same layout twice so that you can tell them apart. In general I don't mind adding this feature but with better rendering but I won't have time to implement it any time soon so patches for this feature are welcome. :)
Created attachment 51547 [details] full screen with label only
Created attachment 51548 [details] il label on dark theme
Created attachment 51550 [details] us label on dark theme
Fair enough. I have attached images of the shadowing on a dark theme. Zoomed in they look fine, but I have trouble reading them at normal size. I had been using the flag as a back ground for the text, ie the US flag with 'asd' on it for qwerty layout, the US flag with 'aoe' on it for a Dvorák layout and 'il' on an Israeli flag for the Hebrew layout.
Agree doesn't look very readable - I'll take a look if shadowing can be stronger.
(In reply to comment #5) > Created an attachment (id=51550) [details] > us label on dark theme I've increased the text shadow radius from 2 to 4 (pushed both to trunk and 4.5 branch), please try and see if it looks readable now. Thanks.
*** Bug 267376 has been marked as a duplicate of this bug. ***
Hi Andriy. Using the text by itself is not enough. Reading and parsing text is much slower and more demanding than parsing an icon: that is why racecars still use manual gauges and even the Space Shuttle's glass cockpit simulates analogue gauges. I am currently using text-only as a workaround (as you mentioned in my dupe) but even with improved shadowing it is not ideal. Thanks.
Dotan, I think reading and parsing text over striped and colored background probably would not be better
> Dotan, I think reading and parsing text over striped > and colored background probably would not be better > Actually, it works for the following reasons: 1) The colours and shapes of the flag are easy to recognise from the corner of the eye without looking for them. For languages with a single layout one does not even need to find and parse the text, a quick glance in the System Tray's direction is sufficient. 2) For languages with multiple layouts the indicator can be found quickly due to having an icon (the flag itself). The keyboard indicator is not like other System Tray icons which are rarely looked for. This one needs to be easy to spot, the user will look for it each time he begins typing.
I use two variants of Serbian keyboard, so the option of having both flag and text label for a layout was really useful to me. I was very disappointed to see it abandoned. I hope you can bring it back - doesn't seem like too much hard work!
Git commit 314823a29b598ca2c4577028c43e2b756b4d7bb6 by Andriy Rysin. Committed on 18/09/2011 at 16:28. Pushed by rysin into branch 'master'. Allow flag and label in keyboard layout indicator FEATURE: 249121 M +92 -28 kcontrol/keyboard/flags.cpp M +3 -0 kcontrol/keyboard/flags.h M +5 -6 kcontrol/keyboard/kcm_add_layout_dialog.cpp M +1 -1 kcontrol/keyboard/kcm_add_layout_dialog.h M +8 -1 kcontrol/keyboard/kcm_keyboard.ui M +17 -4 kcontrol/keyboard/kcm_keyboard_widget.cpp M +8 -8 kcontrol/keyboard/kcm_view_models.cpp M +9 -5 kcontrol/keyboard/keyboard_applet.cpp M +22 -3 kcontrol/keyboard/keyboard_config.cpp M +13 -1 kcontrol/keyboard/keyboard_config.h M +7 -0 kcontrol/keyboard/layout_memory.cpp M +1 -1 kcontrol/keyboard/layout_tray_icon.cpp M +1 -1 kcontrol/keyboard/layout_widget.cpp M +1 -1 kcontrol/keyboard/layouts_menu.cpp http://commits.kde.org/kde-workspace/314823a29b598ca2c4577028c43e2b756b4d7bb6
Thank you Andriy!
Yeah thanks! Much appreciated..