Bug 245342 - Context View: Wrong applet size
Summary: Context View: Wrong applet size
Status: RESOLVED NOT A BUG
Alias: None
Product: plasma4
Classification: Unmaintained
Component: general (show other bugs)
Version: 4.5 and older
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 249758 252418 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-21 19:04 UTC by Christian (Fuchs)
Modified: 2012-05-17 14:03 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Amarok in KDE 4.5 (74.31 KB, image/png)
2010-08-01 16:36 UTC, Alexander
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2010-07-21 19:04:26 UTC
Version:           2.3.1-GIT (using Devel) 
OS:                Linux

When starting amarok, the applets in context view (e.g. Lyrics, similar artists) are way to small (width and height). 

They change to the correct size when either
1) I resize the context view
2) I resize the whole application
3) I toggle lock/unlock layout

This happens with Qt 4.7 trunk (from today) and amarok from git (from today), KDE is 4.5 RC2. 

I was told in IRC that this might be KDE related, but I should report it against amarok anyway. 

Please let me know if you need further information (e.g. debug output, traces etc.) 

Kind regards


Reproducible: Always

Steps to Reproduce:
Launch amarok 

Actual Results:  
Context view Applets have the wrong size

Expected Results:  
Context view Applets have the correct size 


A workaround is to 

qdbus org.kde.amarok /amarok/MainWindow org.kde.amarok.MainWindow.setLayoutLocked false
qdbus org.kde.amarok /amarok/MainWindow org.kde.amarok.MainWindow.setLayoutLocked true

on startup.
Comment 1 Myriam Schweingruber 2010-07-22 00:40:51 UTC
Confirmed
Comment 2 Leo Franchi 2010-07-22 03:35:44 UTC
commit 2e6be3107e8eba174c25260ec4ca5c97b6635b63
Author: Leo Franchi <lfranchi@kde.org>
Date:   Wed Jul 21 21:34:34 2010 -0400

    Kick context view into resizing after load.
    
    BUG: 245342

diff --git a/src/context/ContextDock.cpp b/src/context/ContextDock.cpp
index 411b2f6..1cdeb10 100644
--- a/src/context/ContextDock.cpp
+++ b/src/context/ContextDock.cpp
@@ -74,6 +74,7 @@ ContextDock::createContextView( Plasma::Containment *containment )
     connect( m_contextToolbarView, SIGNAL( hideAppletExplorer() ), m_contextView, SLOT( hideAppletExplorer() ) );
     connect( m_contextToolbarView, SIGNAL( showAppletExplorer() ), m_contextView, SLOT( showAppletExplorer() ) );
     m_contextView->showHome();
+    m_contextView->resize( sizeHint() );
     PERF_LOG( "ContexView created" )
 
 }
Comment 3 Leo Franchi 2010-07-22 04:07:57 UTC
hmm, not completely fixed, damn.
Comment 4 Alexander 2010-08-01 16:36:46 UTC
Created attachment 49729 [details]
Amarok in KDE 4.5

As you can see on the screen shot, in KDE 4.5 context view looks broken.
Comment 5 Myriam Schweingruber 2010-08-08 01:15:44 UTC
The last git commits solved this for me, could you all please check again?
Comment 6 Alexander 2010-08-08 09:52:27 UTC
The bug that was showed on my screenshot is not fixed. But seems that this is a some different bug, and, probably, I should create a new bug report?

Also, after the "mouseover" event of the Context view, Current track and Lyrics applets return to normal width, but Video clip applet not.
Comment 7 Myriam Schweingruber 2010-08-08 12:43:43 UTC
That might well be a problem related to the Video applet in that case, see also bug 214156
Comment 8 Alexander 2010-08-08 12:55:44 UTC
(In reply to comment #7)
I think it is not, because all applets on my screenshot are broken and because I am do not talking about video playback.
Comment 9 Myriam Schweingruber 2010-08-08 13:14:37 UTC
Right, sorry for the confusion. Do your applets resize when you change the width of the Context View? Then this is the same bug, if not the bug is different.
Comment 10 Alexander 2010-08-08 13:51:23 UTC
(In reply to comment #9)
That's all right. Yes, they do, except of the Video applet — it doesn't.
Comment 11 Myriam Schweingruber 2010-08-08 14:35:41 UTC
I think tis is particular to the video applet, then, please make a new report.
Comment 12 Christian (Fuchs) 2010-08-08 20:53:40 UTC
I can confirm that the other applets are now sized correctly. 
But I can also confirm the issue with the video applet. 

However, I guess this particular report can be marked as fixed. If you feel so and want a separate report for the video applet, please close this one. I leave it as open in the meantime. 

Thanks for the fix. 

Kind regards
Comment 13 Myriam Schweingruber 2010-08-08 22:43:41 UTC
Thank you for the feedback. It would be good to open a new report for the Video applet, as it's problem is not necessarily the same.
Comment 14 Myriam Schweingruber 2010-08-09 12:33:14 UTC
Ouch, it's back with the latest git build :)
Comment 15 Leo Franchi 2010-08-25 18:46:46 UTC
Fixed in git as of aac7ab92d3831b00d94707fbcf86cbcebf1db051
Comment 16 Myriam Schweingruber 2010-08-26 10:47:44 UTC
Definitely :)
Comment 17 Alexander 2010-08-27 13:22:59 UTC
(In reply to comment #15)
Not for me.
Comment 18 Myriam Schweingruber 2010-08-27 13:37:56 UTC
Yep, it is back here, too :(
Comment 19 Martin Blumenstingl 2010-08-27 19:11:26 UTC
also not fixed for me (KDE 4.5.0 and Qt 4.6.3)
Comment 20 Martin Blumenstingl 2010-08-27 21:23:25 UTC
Hi,

can someone please mark this patch as "FIXED - UPSTREAM"?
This was a bug in KDE 4.5's plasma.

Here's a snipped from the conversation with notmart on irc:
<notmart> one line patch in libplasma, backported to 4.5 as well

The svn revision for this fix is 1168893.
Oh and thanks notmart :)

Regards,
Martin
Comment 21 Myriam Schweingruber 2010-08-28 08:55:32 UTC
Is this in time for KDE 4.5.1 or will it be in 4.5.2 only?
Comment 22 Myriam Schweingruber 2010-08-28 08:56:51 UTC
See comment #21
Comment 23 Martin Blumenstingl 2010-08-28 16:00:53 UTC
looks like it didn't make it into 4.5.1 anymore :(
Comment 24 Myriam Schweingruber 2010-08-28 17:00:19 UTC
*sigh*, that's what I suspected already :(
Comment 25 Myriam Schweingruber 2010-09-01 15:48:29 UTC
*** Bug 249758 has been marked as a duplicate of this bug. ***
Comment 26 Mark Fraser 2010-09-24 17:08:37 UTC
I only started seeing this bug after upgrading Amarok from 2.3.2 beta to 2.3.2. This is with Kubuntu 10.04 and KDE 4.5.1.
Comment 27 Myriam Schweingruber 2010-09-24 22:32:24 UTC
JFYI: this is a plasma bug, fixed in the upcoming KDE 4.5.2
Comment 28 Mark Fraser 2010-09-25 12:44:51 UTC
How come I didn't have the problem with 2.3.2 beta then?
Comment 29 Myriam Schweingruber 2010-09-25 18:07:24 UTC
Read what I said: this does not depend on Amarok, but on Plasma and the KDE version you use
Comment 30 Mark Fraser 2010-09-25 18:42:14 UTC
I read that, but what I was saying is that when I was using 2.3.2 beta I was also using KDE 4.5.1.

When the upgrade from 2.3.2 beta to 2.3.2 came through no other packages were upgraded.
Comment 31 Myriam Schweingruber 2010-09-26 10:22:24 UTC
Simply because we tried to work around this bug for KDE 4.5.1 users, it sadly doesn't work for everyone. No need to be picky about it, this will be definitfely solved once KDE 4.5.2 is out.
Comment 32 Mark Kretschmann 2010-09-26 12:41:24 UTC
@Myriam: I'm sorry to say there is absolutely no fix on the horizon in Plasma itself. The bug fix you're talking about was something different.
Comment 33 Mikko C. 2010-09-26 17:03:29 UTC
Reopening, since it still happens with kde trunk.
See http://i0.simplest-image-hosting.net/168bf183b2abe8bc9188aacc163dd507/plasma-desktopym2004.jpg
Comment 34 Unknown 2010-09-26 19:36:15 UTC
*** Bug 252418 has been marked as a duplicate of this bug. ***
Comment 35 Myriam Schweingruber 2012-05-17 14:03:29 UTC
Closing for lack of feedback. Please feel free to reopen this report if you can still reproduce this with KDE 4.8.3 or later.