Bug 244542 - Object-locked and object-unlocked are too similar
Summary: Object-locked and object-unlocked are too similar
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.20.5
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 22:52 UTC by Nikola Kovacs
Modified: 2021-03-10 23:08 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.81
Sentry Crash Report:


Attachments
Inkscape's layer view (8.98 KB, image/png)
2010-07-13 22:52 UTC, Nikola Kovacs
Details
Inkscape's layer view with fallback icon (9.59 KB, image/png)
2010-07-13 22:59 UTC, Nikola Kovacs
Details
Desaturated object-unlocked.png (3.13 KB, image/png)
2014-02-10 18:48 UTC, Johannes Nieß
Details
Good visual design example from Breeze in 2021 (13.63 KB, image/png)
2021-03-10 19:48 UTC, Johannes Nieß
Details
Bad visual design example from Breeze in 2021 (12.87 KB, image/png)
2021-03-10 19:48 UTC, Johannes Nieß
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Kovacs 2010-07-13 22:52:39 UTC
Created attachment 49131 [details]
Inkscape's layer view 

Version:           unspecified (using Devel) 
OS:                Linux

These two icons so similar that it is almost impossible to differentiate them at smaller sizes. For example, they are used by Inkscape to indicate whether a layer is locked or unlocked. See the attached screenshot - you have to look very closely to see the difference.

Reproducible: Always
Comment 1 Nikola Kovacs 2010-07-13 22:59:29 UTC
Created attachment 49132 [details]
Inkscape's layer view with fallback icon

These are the default icons used when the icon theme doesn't supply them.
Comment 2 pinheiro 2010-07-13 23:10:14 UTC
valid bug
Comment 3 pinheiro 2012-07-16 23:34:54 UTC
do you hapend to know if the fredesktop naming speck as a specific name icon for this?
Comment 4 Johannes Nieß 2014-02-10 18:47:56 UTC
Bug 330947 might be a duplicate of this, caused by digikam.

My proposal for an alternative icon is partial desaturation. A trivial example based on pinheiros icon is atached. I don't request copy rights for it.
Comment 5 Johannes Nieß 2014-02-10 18:48:59 UTC
Created attachment 85084 [details]
Desaturated object-unlocked.png
Comment 6 Justin Zobel 2021-03-09 23:58:31 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.
Comment 7 Johannes Nieß 2021-03-10 19:48:08 UTC
Created attachment 136565 [details]
Good visual design example from Breeze in 2021
Comment 8 Johannes Nieß 2021-03-10 19:48:51 UTC
Created attachment 136566 [details]
Bad visual design example from Breeze in 2021
Comment 9 Johannes Nieß 2021-03-10 20:10:13 UTC
Thanks for digging out this old bug. The overarching visual design issue still exists in several icon sets, but good examples exist as attached.

I've visually all icon sets installed with plasma 5.20.5 . Offenders exist in several of them, including 'High Contrast' (where it has more impact to the audience). Probably due to changing the default icon set, I can no longer find applicable icons in Oxygen. I've changed the affected 'product' accordingly. Thanks for forwarding to all the graphics designers working on all icon sets.
Comment 10 Bug Janitor Service 2021-03-10 20:49:16 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/92
Comment 11 Johannes Nieß 2021-03-10 21:15:13 UTC
(In reply to Bug Janitor Service from comment #10)
> A possibly relevant merge request was started @
> https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/92

Thanks a lot for that nice solution. Thanks also to Justin for waking up that old bug.
Comment 12 Nate Graham 2021-03-10 23:03:31 UTC
Git commit ba656561dea41c570bae1dca88e1247b8a96189a by Nate Graham.
Committed on 10/03/2021 at 20:48.
Pushed by ndavis into branch 'master'.

Make lock icon filled status consistent

Most lock icons were filled when locked and hollow when unlocked, but a
few were not, in particular:
- emblem-unlocked
- folder-locked
- system-lock-screen

This is corrected, and now all locked icons follow the pattern.
FIXED-IN: 5.81

M  +9    -16   icons-dark/actions/32/system-lock-screen.svg
M  +6    -9    icons-dark/emblems/16/emblem-unlocked.svg
M  +6    -9    icons-dark/emblems/22/emblem-unlocked.svg
M  +5    -7    icons-dark/emblems/8/emblem-unlocked.svg
M  +11   -13   icons-dark/places/16/folder-locked.svg
M  +9    -13   icons-dark/places/22/folder-locked.svg
M  +20   -23   icons-dark/places/32/folder-locked.svg
M  +5    -5    icons-dark/places/48/folder-locked.svg
M  +20   -23   icons-dark/places/64/folder-locked.svg
M  +16   -14   icons-dark/places/96/folder-locked.svg
M  +9    -16   icons/actions/32/system-lock-screen.svg
M  +6    -9    icons/emblems/16/emblem-unlocked.svg
M  +6    -9    icons/emblems/22/emblem-unlocked.svg
M  +4    -6    icons/emblems/8/emblem-unlocked.svg
M  +11   -13   icons/places/16/folder-locked.svg
M  +9    -13   icons/places/22/folder-locked.svg
M  +20   -23   icons/places/32/folder-locked.svg
M  +5    -5    icons/places/48/folder-locked.svg
M  +20   -23   icons/places/64/folder-locked.svg
M  +16   -14   icons/places/96/folder-locked.svg

https://invent.kde.org/frameworks/breeze-icons/commit/ba656561dea41c570bae1dca88e1247b8a96189a