Version: 2.4.3 (using KDE 4.4.3) OS: Linux Apparently Konsole selects the tab to the right when closing a tab, and wraps around to the first one when the rightmost tab gets closed. When closing a tab, the the previously selected tab should get focused. This is a huge usability problem, when you have multiple tabs (5+ opened) and often open and close new ones (e.g. when configuring your shell config): the new tab gets opened at the end, and when it gets closed, you have to figure which tab you were working in before. Reproducible: Always Steps to Reproduce: 1. Open two tabs 2. Go to the second one 3. Open a new tab (third one), it will get focus 4. Exit the shell Actual Results: The first tab is focused, not the previously selected one. Expected Results: The previously selected tab (from where the new tab was opened) should have focus. An internal stack of recently focused tabs is required (in case you close two or more tabs without opening a new one). When such a stack is available, it would be useful to use it also for navigation: instead of only going to the left/right tab, you could cycle
The current method was done to mimic other KDE apps. See: https://bugs.kde.org/show_bug.cgi?id=183483
Konqueror has an option "Activate previously used tab when closing current tab".
> Konqueror has an option "Activate previously used tab when > closing current tab". I don't see a need for making this optional. Just implement it as the only behavior and be done with it.
*** Bug 250563 has been marked as a duplicate of this bug. ***
SVN commit 1186295 by hindenburg: When closing a tab, select the previously focused tab. BUG: 240037 FIXED-IN: 4.6 M +1 -0 ViewContainer.cpp M +2 -7 ViewManager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1186295
SVN commit 1186303 by hindenburg: When closing a tab, select the previously focused tab. Backport CCBUG: 240037 M +1 -0 ViewContainer.cpp M +2 -7 ViewManager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1186303
Thank you very much! (although you might have lost a KDE contributor in the short term, because I was about to dig into KDE development to get this fixed..) Thanks. I am very much looking forward to get this as a binary. In case you have some easy pointers to setup Konsole development and junior jobs in the bug tracker, I'd like to join/help with development (and get this fix before the next KDE release).
Daniel, why don't you start with bug 227156 where you already have some instructions how to fix it.
SVN commit 1194920 by hindenburg: Remove previous commit as it cause a lot of crashes for apps using Konsole Part. CCBUG: 240037 M +0 -1 ViewContainer.cpp M +7 -2 ViewManager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1194920
causing crashes - reverted patch https://bugs.kde.org/show_bug.cgi?id=246652
SVN commit 1198147 by hindenburg: Recommit patch as this wasn't causing the crashes. BUG: 240037 M +1 -0 ViewContainer.cpp M +2 -7 ViewManager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1198147