Bug 183483 - Changes to wrong tab on tab close
Summary: Changes to wrong tab on tab close
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 2.2
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-06 22:52 UTC by Albert Astals Cid
Modified: 2009-07-13 22:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2009-02-06 22:52:06 UTC
Version:           2.2 (using 4.2.00 (KDE 4.2.0), Kubuntu packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.27-11-generic

How to reproduce:
 * Open three tabs
 * Write a 1 in the first tab
 * Write a 3 in the third tab
 * Go to the second tab
 * Close it
 * The user ends up in the first tab which is weird in my opinion and not what happened in KDE 3 version
Comment 1 Kurt Hindenburg 2009-07-05 21:07:43 UTC
It looks like it goes to shell-1; it loops to last shell if you quit the first shell.
Comment 2 Albert Astals Cid 2009-07-12 15:42:17 UTC
Exactly what i'm saying, would you accept a patch that fixes this unstandard behaviour?
Comment 3 Kurt Hindenburg 2009-07-12 15:55:32 UTC
Patches are always welcomed; you are going to use the previous session?
Comment 4 Albert Astals Cid 2009-07-12 16:39:36 UTC
What i want to do is make it do what all programs with tabs in KDE do (konsole would do it too if it was using KDE tab classes) that is; if i have three tabs and close the second i'm still at second (the third before closing)
Comment 5 Robert Knight 2009-07-12 17:16:28 UTC
Please post patches to reviewboard.kde.org

Thank-you in advance.
Comment 6 Kurt Hindenburg 2009-07-12 18:30:34 UTC
Bad choice of words: previous = last tab visited
Comment 7 Albert Astals Cid 2009-07-12 18:56:36 UTC
no, not last visited tab.

Now it goes to shell-1 i'll go to shell (was shell+1 before closing) like all KDE does
Comment 8 Albert Astals Cid 2009-07-12 19:24:12 UTC
http://reviewboard.kde.org/r/999/
Comment 9 Albert Astals Cid 2009-07-13 20:07:00 UTC
SVN commit 996026 by aacid:

switch to next tab and not previous on tab close like all other kde apps do
Approved by Robert Knight
BUGS: 183483


 M  +3 -3      ViewManager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=996026
Comment 10 Albert Astals Cid 2009-07-13 20:07:38 UTC
Can i backport the fix to the 4.3 branch?
Comment 11 Robert Knight 2009-07-13 21:54:20 UTC
> Can i backport the fix to the 4.3 branch?

Please do.
Comment 12 Albert Astals Cid 2009-07-13 22:16:44 UTC
SVN commit 996082 by aacid:

switch to next tab and not previous on tab close like all other kde apps do
Approved by Robert Knight
BUGS: 183483


 M  +3 -3      ViewManager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=996082