Bug 233867 - shortcut next random album
Summary: shortcut next random album
Status: RESOLVED DUPLICATE of bug 193342
Alias: None
Product: amarok
Classification: Applications
Component: Shortcuts (show other bugs)
Version: 2.3.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-09 19:41 UTC by Hervé
Modified: 2010-12-12 21:36 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to add "next album" functionality (7.89 KB, patch)
2010-10-18 17:35 UTC, Richard Longland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hervé 2010-04-09 19:41:31 UTC
Version:           2.3.0 (using KDE 4.4.2)
OS:                Linux
Installed from:    Ubuntu Packages

Hello,
I'd like a shortcut that gives the functionality to the action described in " Bug 193342 " => next album while using "album random mode") It would be very nice to skip directly to next album w/o having to skip to it track by track.

amarok 2.3.0 realy rocks, keep going :-D

Rv
Comment 1 Richard Longland 2010-10-18 17:35:52 UTC
Created attachment 52654 [details]
Patch to add "next album" functionality

Use at your own risk! No, seriously.
Comment 2 Richard Longland 2010-10-18 17:39:12 UTC
Hi,

DO NOT USE the above patch unless you're willing to break Amarok. This is something I threw together for myself, and thought that I would share it in case a real developer felt like implementing a cleaned up version.

This has been bugging me for a while. I'm really not very good at coding, but I dug around a little and managed to hack something together to add "next album" skipping. See attached patch. This only works in Random Album mode, and I've shorted the code to "next track" in all other play modes. The patch adds a quick 'n dirty "next album" button to the slim toolbar which contains this functionality. I couldn't figure out how to make this look nice, and I'd rather just have the functionality right now.

I think it would require more than my ability to code this, but I feel like amarok could benefit from a list of upcoming albums in m_plannedAlbums (as is done in random album mode) for ALL play modes. I can't think of a reason why it would hurt, and will add the ability to skip albums easily. I might play around on my end to look at this, but I can't guarantee that it'll be clean ;-)

Cheers,
Rich
Comment 3 Myriam Schweingruber 2010-10-18 22:00:10 UTC
Please submit your patch to http://git.reviewboard.kde.org (register on http://identity.kde.org first), else the developers will not see it.
Comment 4 Richard Longland 2010-10-19 10:08:56 UTC
Myriam,

This patch is certainly not something to be merged into main. It's probably buggy, provides no "skip backward" capability, and adds an ugly double "next track" button. Is there a way to alert the devs without submitting it to the reviewboard? I don't want to clutter it up with rubbish!

In any case, I think I'm going to keep working on my implementation first. I may attempt a global "next album" capability, and figure out a cleaner solution to the two button problem.

Cheers,
Rich
Comment 5 Myriam Schweingruber 2010-10-19 11:47:42 UTC
You should talk to the developers first anyway, be it only to avoid duplicate work from others. Please send your proposition to amarok-devel@kde.org
Comment 6 Myriam Schweingruber 2010-12-12 21:36:58 UTC

*** This bug has been marked as a duplicate of bug 193342 ***