Bug 231535 - Shadow plugin should introduce exceptions
Summary: Shadow plugin should introduce exceptions
Status: RESOLVED DUPLICATE of bug 99198
Alias: None
Product: kwin
Classification: Plasma
Component: compositing (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-21 13:20 UTC by Jakub 'Livio' Rusinek
Modified: 2010-03-22 18:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
GNOME Do with KWin - screenshot (282.18 KB, image/png)
2010-03-21 20:58 UTC, Jakub 'Livio' Rusinek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub 'Livio' Rusinek 2010-03-21 13:20:28 UTC
Version:           4.4.1 (using KDE 4.4.1)
OS:                Linux
Installed from:    openSUSE RPMs

Either in window-specific options or inside shadow plugin settings, there should be an option to disable shadow for specific window(s).

Good example are apps, which use non-rectangular shape or multiple windows, so shadow looks wrong. Try GNOME Do and you'll see multiple, different shadows one under another.
Comment 1 Martin Flöser 2010-03-21 13:31:34 UTC
a shaped window does not receive a shadow by kwin. In that case I'd say that GNOME Do is not a shaped window. Compare to krunner - there is no shadow added by kwin.
Comment 2 Thomas Lübking 2010-03-21 16:07:34 UTC
neither do undecorated ARGB windows, so a window cannot paint it's own shadows and receive the kwin ones.

can you please provide a screenshot? (i have a suspection, but don't know Gnome Go)

note that there's also a window property to override shadows (which can e.g. be set by applicaitions)
Comment 3 Jakub 'Livio' Rusinek 2010-03-21 20:58:20 UTC
Created attachment 41817 [details]
GNOME Do with KWin - screenshot
Comment 4 Jakub 'Livio' Rusinek 2010-03-21 21:03:21 UTC
> note that there's also a window property to override shadows 
> (which can e.g. be set by applicaitions)

I hope you don't believe GNOME app would add exceptions for KWin (; .
Comment 5 Thomas Lübking 2010-03-21 21:19:08 UTC
Sure I do ;-)

This is however not exactly what i had expected.
Do you happen to use the XRender backend?
Comment 6 Thomas Lübking 2010-03-21 23:46:55 UTC
one other thing just _popping_ into my mind - may this be a "popup" window?
(usually they hide if you click somewhere else - if not, try "xprop | grep NET_WM" on it.
Comment 7 Jakub 'Livio' Rusinek 2010-03-22 10:58:07 UTC
> Do you happen to use the XRender backend?

No, I'm using OpenGL one.

> may this be a "popup" window?

It probably is a popup. Its type is set to "splash" and it works as you described it.
Comment 8 Martin Flöser 2010-03-22 11:13:58 UTC
(In reply to comment #7)
> > may this be a "popup" window?
> 
> It probably is a popup. Its type is set to "splash" and it works as you
> described it.
It shouldn't do that. Let me cite the specification: "_NET_WM_WINDOW_TYPE_SPLASH indicates that the window is a splash screen displayed as an application is starting up." The window is definately not a splash screen.

My fair guess is that it is working around an issue in either Metacity or Compiz. Given the name I do not expect that the developers have ever tried to run GNOME Do with KWin. I would suggest that you report the issue to the GNOME Do developers.
Comment 9 Jakub 'Livio' Rusinek 2010-03-22 16:17:45 UTC
I didn't intend to talk about GNOME do issue here, it's just one programme I'd like to work around somehow different, than changing focus stealing prevention to none.

And regarding splash screen definition, true, I agree with it, but Do's window is using splash wm-tip.

Issue was reported to them many times.

I just want to disable shadow for specific window and I'm looking forward to extending window-specific options.
Comment 10 Martin Flöser 2010-03-22 16:31:37 UTC
(In reply to comment #9)
> I just want to disable shadow for specific window and I'm looking forward to
> extending window-specific options.
This requires to write a complete framework, which requires a lot of work. I doubt there will be such a framework in 4.5, so the earliest would be 4.6. That's why I mentioned to ask the GNOME Do developers to fix the issue. (Honestly I'm surprised that kwin allow a splash window to get focus at all)

*** This bug has been marked as a duplicate of bug 99198 ***
Comment 11 Thomas Lübking 2010-03-22 18:40:10 UTC
ok, the shadows then derive from a popup exception in the "no shadows for unique shapes" policy (the reason is that many toolkits/styles provide popups with rounded corners)

we could be a little more picky here and check the shape against it's bounding rect, though this would mean overhead for a rare corner case, as - and

however:
a window with WM_SPLASH + WM_POPUP + a giant empty xshape'd area is just begging for all kinds of troubles (esp. on the focus side, thus clearly a bug on Gnome Do)
they likely want to use an override window, manage focus themselves and pot. grab the pointer/kbd

this particular item could btw, solved by the rule system (as we as mentioned have a property anyway)