(*** This bug was imported into bugs.kde.org ***) Package: keditbookmarks Version: 1.0 (using KDE 2.1.1 - CVS 20010306) Severity: wishlist Installed from: Debian Package 4:2.1.0.1-5 (testing/unstable) Compiler: gcc version 2.95.3 20010219 (prerelease) OS: Linux 2.4.3-pre3 i686 OS/Compiler notes: Hi I only recently discovered that konqueror supports the "favorite icons" that can be set in web pages (/favicon.ico). Therefore none of my bookmarks have this set. Also some of the favicons I've seen change regularly or on special occasions. I would like a) konqueror automatically to refresh / change the favicon of a bookmark if the favicon changed on the site (this can probably be achived without having to reload the favicon itself just by comparing "last edited / changed" valus in the bookmarks file and in the HTTP headers) and/or b) keditbookmarks to offer a "download icon from site" option in addition to the "change icon" option. While b) would probably be much easier I think a) is much more convenient. I will also try to implement this myself (just started C++) if you guide me where to plug this in. Thanks Jens (Submitted via bugs.kde.org) (Called from KBugReport dialog)
*** Bug 48956 has been marked as a duplicate of this bug. ***
i've added a favicon updater. its not completely stable yet but appears to work well enough. just select 'update all favicons' (iirc). any thoughts on this?, automating this from konqueror would be a fair bit of overhead unfortunately so just having the tool in keditbookmarks seems like enough to me. Alex
Subject: Re: refresh/edit favicons On Fri, Feb 21, 2003 at 12:39:59PM -0000, lypanov@kde.org wrote: > i've added a favicon updater. its not completely stable yet but > appears to work well enough. just select 'update all favicons' (iirc). > > any thoughts on this?, automating this from konqueror would be a fair > bit of overhead unfortunately so just having the tool in > keditbookmarks seems like enough to me. Hi, I just updated my CVS - thank you! :-) The feature works, although it pauses (and doesn't continue) on file:/ links, for example. (actually anything except http:// - like fish:// etc). I think it would be sensible to either restrict this to http:// links, or just transparently get/download $URL/favicon.ico no matter via which protocol (so FTP sites and local directories are also handled).
issue 2 is done now, but automatically updating favicons are still on my list. probably a 3.3 thing though, other things to do first. infrastructure is all there though. Alex
Subject: Re: refresh/edit favicons On Thu, Mar 06, 2003 at 11:14:13AM -0000, lypanov@kde.org wrote: > issue 2 is done now, but automatically updating favicons are still on > my list. probably a 3.3 thing though, other things to do first. > infrastructure is all there though. Great. Thanks!
*** Bug 25840 has been marked as a duplicate of this bug. ***
*** Bug 41185 has been marked as a duplicate of this bug. ***
There's been a "update all favicons" menu item in the bookmark editor for some time, which does what I want (basically).
Replaced kde@jensbenecke.de with roland@wertkarten.net due to bounces by reporter
This works pretty well IMHO and reporter is satisfied (comment #8). Will close soon, if nobody disagrees.
The "update all favicons" and "update favicon" does not work very reliable, the update all feature tends to stop/pause without any indication of whats happening. There are no good progress indication of how the update process proceeds. Manually updating the icons one by one with the "update favicon" fails when encountering a site without icon and instead uses the last icon found. In addition the functions follows konquerors cookies policy, instead of always ignoring(Don't need cookies for updating favicon right?) Not good when using "ask for confirmation" as cookie policy.
KDS SVN 3.5 neither the bookmarks editor nor konqueror updates the favicon reliably.
I am noticing this now also on Konqueror 3.5.5. I changed the favicons on a couple of my sites, but konqueror is not noticing the change. It still displays the old icon.
Michael, how can it be closed when the (b) feature is still missing. Such option would really ease the problems when choosing non-default favicon from the site. Currenlty instead of just entering URL, I have to download the icon, run gimp, open saved ico, save it as png, and finally change the icon.
SVN commit 1116050 by dfaure: Unbreak favicon checking; in many error cases it wouldn't proceed to the next item. Also when the cached favicon was recent enough, then the kded module wouldn't emit anything; fixed by adding a "forceDownloadHostIcon" and an error signal in the favicons kded module. CCBUG: 23102 (and probably others) M +9 -4 keditbookmarks/actionsimpl.cpp M +3 -0 keditbookmarks/actionsimpl.h M +52 -35 keditbookmarks/bookmarkiterator.cpp M +40 -22 keditbookmarks/bookmarkiterator.h M +18 -43 keditbookmarks/favicons.cpp M +3 -6 keditbookmarks/favicons.h M +26 -53 keditbookmarks/testlink.cpp M +2 -5 keditbookmarks/testlink.h M +3 -4 keditbookmarks/toplevel.h M +92 -51 keditbookmarks/updater.cpp M +13 -7 keditbookmarks/updater.h M +44 -15 lib/konq/favicons/favicons.cpp M +23 -5 lib/konq/favicons/favicons.h M +8 -0 lib/konq/favicons/org.kde.FavIcon.xml WebSVN link: http://websvn.kde.org/?view=rev&revision=1116050
SVN commit 1119159 by dfaure: - rename updater.cpp to faviconupdater.cpp to match classname - connect to completed(bool) so that we get notified even in case of a delayed redirect (testcase: http://www.citefutee.com/orienter/rer.php). This was another case of "update all favicons" hanging forever. CCBUG: 23102 M +1 -1 CMakeLists.txt M +1 -1 favicons.cpp A faviconupdater.cpp updater.cpp#1118942 [License: GPL (v2/3)] A faviconupdater.h updater.h#1118942 [License: GPL (v2/3)] D updater.cpp D updater.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1119159